Fix an issue with comment scrolling offset #1639
Merged
+29
−4
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This is a quick fix related to comment scrolling in the new post page. It looks like my change in #1630 inadvertently allowed the comments to be scrolled to the very top of the display, due to the extended
SafeArea
, which is now partly covered by aContainer
. This fix adds an offset toanimateToItem
to account for the status bar.However, this turned out to be tricky, because as a child widget of
SafeArea(top: false)
, accessing the status bar height withMediaQuery.of(context).padding.top
always returns0
. Therefore I had to capture the height outside theSafeArea
and pass it in. I also had to remove the offset when the top bar is pinned. Now it works well!Issue Being Fixed
Issue Number: N/A
Screenshots / Recordings
Before
comment_scroll_before.mp4
After
comment_scroll_after.mp4
Checklist
semanticLabel
s where applicable for accessibility?