Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with app hanging after update to v0.6.0-2 #1634

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

hjiangsu
Copy link
Member

Pull Request Description

This PR attempts to fix an issue with the latest nightly build hanging at the splash screen. I believe this is the cause of the issue but am not 100% sure, however, it could be due to a null check error when Material You theme is enabled.

I'll be creating a new nightly build off of this branch since there's been commits made already to the develop branch!

Issue Being Fixed

Issue Number: N/A

Screenshots / Recordings

Checklist

  • If a new package was added, did you ensure it uses an appropriate license and is actively maintained?
  • Did you use localized strings (and added appropriate descriptions) where applicable?
  • Did you add semanticLabels where applicable for accessibility?

Copy link
Member

@micahmo micahmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although will the removals break the color scheme?

@hjiangsu
Copy link
Member Author

hjiangsu commented Dec 12, 2024

will the removals break the color scheme?

This should only affect users using Material You and a dark theme applied - I figured it'd be better to remove it now and make a proper fix for it once I push out a new nightly build!

@hjiangsu hjiangsu merged commit ad5280d into develop Dec 13, 2024
1 check passed
@hjiangsu hjiangsu deleted the fix/app-hang branch December 13, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants