Fix text hint color #1621
Merged
Fix text hint color #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjiangsu
reviewed
Dec 4, 2024
lib/main.dart
Outdated
| @@ -234,6 +234,22 @@ class _ThunderAppState extends State<ThunderApp> { | |||
| theme = theme.copyWith(pageTransitionsTheme: pageTransitionsTheme); | |||
There was a problem hiding this comment.
I think perhaps moving the additional styling into here would make more sense (since we're already modifying the themes here)!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR fixes an issue where the text field hint text color looks much darker than before (and darker even than the text that gets typed!).
I didn't bother doing an exact color match, I just wanted the text to look slightly faded.
Again I tested with light, dark, and pure black.
Issue Being Fixed
Issue Number: #1565 (comment)
Screenshots / Recordings
You'll notice that the text field size is also different. I plan to address that separately. It was also mentioned in the linked comment.
ShareX_IsjiqAOgQw.mp4
Checklist
semanticLabels where applicable for accessibility?