fix(cab): bug in handling accNo

thu-info-community · Sep 3, 2023 · 8738e5c · 8738e5c
1 parent 72c2b8a
commit 8738e5c
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/__tests__/auth.ts b/__tests__/auth.ts
@@ -30,6 +30,8 @@ it("should login successfully.", async () => {
     expect(dayjs(firstDay).day()).toEqual(1);
     expect((await helper.getCrTimetable()).length).toBeGreaterThan(0);
     expect((await helper.getCampusCardInfo()).balance).toBeGreaterThanOrEqual(0);
+    await helper.getLibraryRoomBookingInfoList();
+    expect(helper.getLibraryRoomAccNo() === -1).toBeFalsy();
     await helper.logout();
     expect(helper.mocked()).toEqual(false);
 }, 60000);
diff --git a/release b/release
@@ -1,3 +1 @@
-internal: introduce a new `RoamingPolicy` (`"cab"`) for cab.lib.tsinghua.edu.cn login to make code-scan happy
-feat: add an API to get accNo of cab.lib.tsinghua.edu.cn
-fix: type of accNo
+fix(cab): bug in handling accNo
diff --git a/src/lib/library.ts b/src/lib/library.ts
@@ -414,10 +414,11 @@ export const cabLogin = async (helper: InfoHelper): Promise<void> => {
         throw new Error("Failed to get payload in cabLogin. Retry later.");
     }
     await roam(helper, "cab", payload);
-    const {pid} = await cabFetch(LIBRARY_ROOM_BOOKING_USER_INFO_URL);
+    const {pid, accNo} = await cabFetch(LIBRARY_ROOM_BOOKING_USER_INFO_URL);
     if (pid !== helper.userId) {
         throw new Error("Failed to get pid in cabLogin. Retry later.");
     }
+    accountBaseInfo.accNo = accNo;
 };
 
 export const getLibraryRoomBookingInfoList = async (helper: InfoHelper): Promise<LibRoomInfo[]> => {