System tests for KEEP<>T staking contracts interactions

[pdyraga]

System tests are performed on mainnet block 13619810 fork chain using three real stakers from KEEP network: liquid token staker, managed grant staker, and non-managed grant staker.

Stake delegation

• Given I am KEEP network liquid token staker, when I have authorized T staking contract, when I have not undelegated my legacy stake, stakeKeep should copy my stake to T staking contract.
• Given I am KEEP network liquid token staker, when I have authorized T staking contract, when I have undelegated my legacy stake, stakeKeep should revert.

Top-ups

• Given I am KEEP network liquid token staker, when I copied my stake to T staking contract, when I executed top-up of my legacy stake, topUpKeep should top-up my stake in T staking contract.

Stake undelegation

• Given I am KEEP network liquid token staker, when I copied my stake to T staking contract, when I authorized and deauthorized application, unstakeKeep should release my KEEP stake.
• Given I am KEEP network liquid token staker, when I copied my stake to T staking contract, when I authorized and deauthorized application, unstakeKeep should let me undelegate my KEEP stake.

Slashing

• Given I am KEEP network liquid token staker, when I copied my stake to T staking contract, when I authorized application, when I got slashed by the application, processSlashing should slash my KEEP stake.
• Given I am KEEP network liquid token staker, when I copied my stake to T staking contract, when I authorized application, when I got slashed by the application, notifyKeepStakeDiscrepancy should revert.
• Given I am KEEP network liquid token staker, when I copied my stake to T staking contract, when I authorized application, when the application seized my stake, processSlashing should seize my KEEP stake.
• Given I am KEEP network liquid token staker, when I copied my stake to T staking contract, when I authorized application, when the application seized my stake, notifyKeepStakeDiscrepancy should revert.

Exactly the same tests are repeated for two other types of actors:

• Given I am KEEP network managed grant staker...
• Given I am KEEP network non-managed grant staker...

[michalinacienciala]

@pdyraga, what do you think about adding a test checking if unstakeKeep gets reverted if the amount of T after the unstake would be lower than the highest application authorization?

"Given I am KEEP network [...], when I copied my stake to T staking contract, when I authorized application, unstakeKeep should revert."

[nkuba]

Can we migrate system tests to TS?

[pdyraga]

Can we migrate system tests to TS?

Not a bad idea but I'd do that later for all tests. This is captured in #5.

[pdyraga]

@pdyraga, what do you think about adding a test checking if unstakeKeep gets reverted if the amount of T after the unstake would be lower than the highest application authorization?

"Given I am KEEP network [...], when I copied my stake to T staking contract, when I authorized application, unstakeKeep should revert."

This logic in unstakeKeep does not involve interaction with KEEP staking contract and is covered by unit tests. I would prefer to leave this part to unit tests and have system tests covering only these paths where KEEP staking contract is involved. Especially that system tests are really expensive to execute compared with unit tests.

solidity-contracts/contracts/staking/TokenStaking.sol

Lines 758 to 772 in a70d05c

	function unstakeKeep(address operator)
	external
	override
	onlyOwnerOrOperator(operator)
	{
	OperatorInfo storage operatorStruct = operators[operator];
	uint96 keepInTStake = operatorStruct.keepInTStake;
	require(keepInTStake != 0, "Nothing to unstake");
	require(
	getMinStaked(operator, StakeType.KEEP) == 0,
	"Keep stake still authorized"
	);
	emit Unstaked(operator, keepInTStake);
	operatorStruct.keepInTStake = 0;
	decreaseStakeCheckpoint(operator, keepInTStake);

[nkuba]

LGTM!