-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for deployment on Goerli testnet #114
Commits on Jul 8, 2022
-
Add support for deployment on Goerli testnet
Görli became a recommended test network after Ropsten's deprecation notice (https://blog.ethereum.org/2022/06/21/testnet-deprecation/). We're modifying GitHub Actions workflow for deploying contracts to support the deployment on Görli. We're also leaving the possibility of deployment on Ropsten (this will be removed once we have the Görli deployment battle-tested and Ropsten gets shut down). We also change the way we handle `keep-core` dependency - in V2 of our system we'll no longer planning to publish ne `keep-core` packages - hence we hardcode used version of the package for given testnet. NOTE: We're temporarily using some testing configuration in the workflow, which needs to be removed before merge to `main`.
Configuration menu - View commit details
-
Copy full SHA for 439981e - Browse repository at this point
Copy the full SHA 439981eView commit details
Commits on Jul 13, 2022
-
Remove Ropsten-related config from deployment job
As the Ropsten testnet becomes deprecated in the near future, we are switching to deployment on Goerli. If deployment on Ropsten will be needed in the interm period, we will do it manually, not via GH Actions.
Configuration menu - View commit details
-
Copy full SHA for 65184cf - Browse repository at this point
Copy the full SHA 65184cfView commit details
Commits on Jul 14, 2022
-
Disable part of workflow to quickly verify
Notify CI...
stepChange is only temporary, it should be reverted before merge to `main`.
Configuration menu - View commit details
-
Copy full SHA for da8a58f - Browse repository at this point
Copy the full SHA da8a58fView commit details
Commits on Jul 15, 2022
-
We are removing the temporary configuration used for workflow testing. We are also bumping the version of used custom GH actions from `v1` to `v2`, as `v2` uses the new order of modules executions.
Configuration menu - View commit details
-
Copy full SHA for c7e8fb1 - Browse repository at this point
Copy the full SHA c7e8fb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5fbb781 - Browse repository at this point
Copy the full SHA 5fbb781View commit details
Commits on Jul 27, 2022
-
Use tag when resolving
keep-core
contractsWe tag the latest `@keep-network/keep-core` package containing contracts migrated on some environment with tag that is a name of that environment. We can use that tag instead of the explicit version when resolving contracts of dependant projects.
Configuration menu - View commit details
-
Copy full SHA for c9f33ca - Browse repository at this point
Copy the full SHA c9f33caView commit details
Commits on Aug 2, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0002541 - Browse repository at this point
Copy the full SHA 0002541View commit details -
Remove check of
environment
in deployments jobRight now we only support `goerli` network and we expect that the workflow (when triggered manually) is always dispatched with this `environment`. Previously we introduced `github.event.inputs.environment == 'goerli'` condition to not run the deploy job if workflow gets accidentally run on a different environment. But even without this condition we don't risk publishing of a package with some invalid contracts - deploy will fail either due to unsupported `environment` or due to incorrect account being used. Actually, returning error instead of cleanly exiting the workflow may be a better idea in case wrong `environment` is provided - this will alarm the scheduler that something went wrong with the deployment.
Configuration menu - View commit details
-
Copy full SHA for 8c0c77d - Browse repository at this point
Copy the full SHA 8c0c77dView commit details
Commits on Aug 3, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 11c9d66 - Browse repository at this point
Copy the full SHA 11c9d66View commit details