Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for deployment on Goerli testnet #114

Merged
merged 9 commits into from
Aug 3, 2022
Merged

Add support for deployment on Goerli testnet #114

merged 9 commits into from
Aug 3, 2022

Commits on Jul 8, 2022

  1. Add support for deployment on Goerli testnet

    Görli became a recommended test network after Ropsten's deprecation
    notice (https://blog.ethereum.org/2022/06/21/testnet-deprecation/).
    We're modifying GitHub Actions workflow for deploying contracts to
    support the deployment on Görli. We're also leaving the possibility of
    deployment on Ropsten (this will be removed once we have the Görli
    deployment battle-tested and Ropsten gets shut down).
    We also change the way we handle `keep-core` dependency - in V2 of our
    system we'll no longer planning to publish ne `keep-core` packages -
    hence we hardcode used version of the package for given testnet.
    
    NOTE: We're temporarily using some testing configuration in the
    workflow, which needs to be removed before merge to `main`.
    michalinacienciala committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    439981e View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. Remove Ropsten-related config from deployment job

    As the Ropsten testnet becomes deprecated in the near future, we are
    switching to deployment on Goerli. If deployment on Ropsten will be
    needed in the interm period, we will do it manually, not via GH Actions.
    michalinacienciala committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    65184cf View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. Disable part of workflow to quickly verify Notify CI... step

    Change is only temporary, it should be reverted before merge to `main`.
    michalinacienciala committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    da8a58f View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2022

  1. Remove testing configuration

    We are removing the temporary configuration used for workflow testing.
    We are also bumping the version of used custom GH actions from `v1` to
    `v2`, as `v2` uses the new order of modules executions.
    michalinacienciala committed Jul 15, 2022
    Configuration menu
    Copy the full SHA
    c7e8fb1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    5fbb781 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Use tag when resolving keep-core contracts

    We tag the latest `@keep-network/keep-core` package containing contracts
    migrated on some environment with tag that is a name of that
    environment. We can use that tag instead of the explicit version when
    resolving contracts of dependant projects.
    michalinacienciala committed Jul 27, 2022
    Configuration menu
    Copy the full SHA
    c9f33ca View commit details
    Browse the repository at this point in the history

Commits on Aug 2, 2022

  1. Configuration menu
    Copy the full SHA
    0002541 View commit details
    Browse the repository at this point in the history
  2. Remove check of environment in deployments job

    Right now we only support `goerli` network and we expect that the
    workflow (when triggered manually) is always dispatched with this
    `environment`. Previously we introduced
    `github.event.inputs.environment == 'goerli'` condition to not run the
    deploy job if workflow gets accidentally run on a different environment.
    But even without this condition we don't risk publishing of a package
    with some invalid contracts - deploy will fail either due to
    unsupported `environment` or due to incorrect account being used.
    Actually, returning error instead of cleanly exiting the workflow may be
    a better idea in case wrong `environment` is provided - this will alarm
    the scheduler that something went wrong with the deployment.
    michalinacienciala committed Aug 2, 2022
    Configuration menu
    Copy the full SHA
    8c0c77d View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2022

  1. Configuration menu
    Copy the full SHA
    11c9d66 View commit details
    Browse the repository at this point in the history