-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Externalize text and images to allow easier usage of BYOR #261
base: master
Are you sure you want to change the base?
Conversation
Hi @jfbenckhuijsen , thanks for raising this PR! Thanks! |
Hi @devansh-sharma-tw ! Any idea on when that refactor will be merged and made public to us all? |
@devansh-sharma-tw planning to rework this PR based on the new design. However, before doing that, Id first like to discuss the direction to get it easier accepted into mainly. Currently from what I've seen, the new design uses more pure HTML instead of using javascript to create all content. So for now, I'm imagining something along the lines of:
Mind you, I'll probably only target the new UI |
Hi @jfbenckhuijsen , Apologies for the late reply! The approach to changes you mention sound good. We have used more base HTML in the new UI code and have attempted to build the other components (banner, subnav, search etc.) with their own HTML/JS/CSS chunks (see components folder) and combine them together at the end.
That works! Thanks! |
@jfbenckhuijsen / @devansh-sharma-tw What is the status on the new design and updating this PR? We would also be interested in being able to configure the BYOR. I was looking to create a PR for it and found this one. Would a new PR be valuable at this point? |
Hi @kimdhendrick, the new design has been live for several months now, so this PR needs to be updated to reflect the latest code if you think there would still be value in that improvement. Thanks! |
BYOR has a number of places where Thoughtworks related content is used. This change allows a user of this (awesome) project to more easily change this to his own styling.