ADM-898: [frontend] fix: fix flag card logic #109
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… exclusive with 'flag as block' (#1350) * ADM-898:[backend] feat: should not export cycle time flag on table header when not consider flag as block * ADM-898:[frontend]feat: not show flagCard when board mapping table has ‘block’ column * ADM-898:[frontend]feat: warning pop-up when conflict * ADM-898:[frontend]refactor: refactor codes * ADM-898:[frontend]refactor: remove fromFlag * ADM-898:[frontend]feat: not show flagCard when board mapping table has ‘block’ column * ADM-873-bug:[backend] feat: add test for as flag is block is false * ADM-898:[frontend]feat: add status logic * ADM-898:[frontend]refactor: refactor code * ADM-898:[backend] fix: fix bug for not calculate flag block to cycle when consider flag as block * ADM-886:[docs]docs: refactor chart API docs sequence diagram (#1339) * ADM-886:[docs]docs: update chart API image size * ADM-886:[docs]docs: update chart API docs content * ADM-886:[docs]docs: refactor chart API docs * ADM-886:[docs]docs: refactor chart API docs sequence diagram * ADM 834 add frontend validation to board Id (#1338) * ADM-834:[frontend]feat: fix rebase * ADM-834:[backend]feat: added api for domain url check * ADM-834:[backend]feat: add dashboard api for site check * ADM-834:[backend]feat: added api for domain url check * ADM-834:[frontend]fix: fix rebase * ADM-834:[frontend]fix: add regex validation to board id * ADM-834:[frontend]fix: fix lint * ADM 751 [docs]docs: fix readme in board mappings part (#1334) * ADM-751:[frontend]feat: add by status e2e test flow into import test * ADM-751:[frontend]feat: add more flow in create test * ADM-751:[frontend]feat: fix lint and refactor fixture file * ADM-751:[frontend]feat: fix by state flow and add new test * ADM-751:[frontend]feat: refactored file strcture and implemented new e2e test for cycle time status testing, just need to fix the data then * ADM-751:[frontend]feat: rework the by status flow e2e test, remove unnecessary steps * ADM-751:[frontend]feat: fix test flow again * ADM-751:[frontend]feat: fix type check * ADM-751:[frontend]feat: add status flow e2e test in import test * ADM-751:[frontend]fix: fix lint * ADM-882:[backend]feat: add import json file * ADM-751:[frontend]fix: refactor code * ADM-751:[frontend]fix: refactor code fix type * ADM-751:[docs]docs: fix readme in board mappings * ADM-751:[docs]docs: remove conflicted rework part * ADM-751 refactor --------- Co-authored-by: guzhongren <[email protected]> * chore(sbom): generate sbom when releasing (#1340) * ADM-833:[frontend]feat:add e2e unhappy path scenarios (#1328) * ADM-833:[frontend]feat:add e2e unhappy path scenarios ADM-833: [frontend] add e2e test scenarios ADM-833: [frontend] fix: fix code style error ADM-833: [frontend] feat: add unhappy path scenoria ADM-833: [frontend] feat: optimize add and remove new pipeline,add unhappy path template ADM-833: [frontend] feat: optimize remove new pipeline,unhappy path template ADM-833: [frontend] feat: optimize remove new pipeline,unhappy path template ADM-833:[frontend]feat:merge unhappy path scenario ADM-833: [frontend] update: update e2e test scenarios ADM-833: [frontend] fix: fix code style error ADM-833: [frontend] update: update e2e test scenarios ADM-833: [frontend] update: update e2e test scenarios ADM-833: [frontend] fix: fix e2e test error ADM-833:[frontend]feat:distinguish major and unhappy path test in local environment ADM-833: [frontend] feat: sperate major and all ADM-833[frontend]feat:change branch invalid error message ADM-833: [frontend] fix: fix index.ts error ADM-833: [frontend] fix: remove the log file ADM-833: [frontend] fix: fix conflict with main branch ADM-833: [frontend] fix: revert readme ADM-833: [frontend] fix: remove log file ADM-833: [frontend] fix: modify .gitignore, add omit logs * ADM-833 fix path * ADM-833: [frontend] fix: update the spec location * ADM-833: [frontend] fix: fix daterange error * ADM-833: [frontend] fix: fix review error * ADM-833: [frontend] fix: fix review error --------- Co-authored-by: YaoZhang-Daniel <[email protected]> Co-authored-by: guzhongren <[email protected]> * ADM-833: [frontend] fix: fix env error (#1341) * ADM-833:[frontend]feat:add e2e unhappy path scenarios ADM-833: [frontend] add e2e test scenarios ADM-833: [frontend] fix: fix code style error ADM-833: [frontend] feat: add unhappy path scenoria ADM-833: [frontend] feat: optimize add and remove new pipeline,add unhappy path template ADM-833: [frontend] feat: optimize remove new pipeline,unhappy path template ADM-833: [frontend] feat: optimize remove new pipeline,unhappy path template ADM-833:[frontend]feat:merge unhappy path scenario ADM-833: [frontend] update: update e2e test scenarios ADM-833: [frontend] fix: fix code style error ADM-833: [frontend] update: update e2e test scenarios ADM-833: [frontend] update: update e2e test scenarios ADM-833: [frontend] fix: fix e2e test error ADM-833:[frontend]feat:distinguish major and unhappy path test in local environment ADM-833: [frontend] feat: sperate major and all ADM-833[frontend]feat:change branch invalid error message ADM-833: [frontend] fix: fix index.ts error ADM-833: [frontend] fix: remove the log file ADM-833: [frontend] fix: fix conflict with main branch ADM-833: [frontend] fix: revert readme ADM-833: [frontend] fix: remove log file ADM-833: [frontend] fix: modify .gitignore, add omit logs * ADM-833 fix path * ADM-833: [frontend] fix: update the spec location * ADM-833: [frontend] fix: fix daterange error * ADM-833: [frontend] fix: fix review error * ADM-833: [frontend] fix: fix review error * ADM-833: [frontend] fix: fix env error --------- Co-authored-by: YaoZhang-Daniel <[email protected]> Co-authored-by: guzhongren <[email protected]> * Revert "ADM-833: [frontend] fix: fix env error (#1341)" (#1344) This reverts commit eed90dc. * [ADM-833][frontend]: chore: fix the e2e env injection error. (#1345) * refactor(e2e): name conversion[frontend] * fix(e2e): fix type check[frontend] * ADM-898:[frontend]fix: fix test * ADM-898:[frontend]feat: add test for CycleTime * ADM-898:[frontend]fix: fix UpperCase error * ADM-898:[frontend]fix: fix default value * ADM-898:[frontend]fix: fix import treatFlagCardAsBlock value * ADM-898:[backend] fix: repair e2e test * ADM-898:[backend] fix: repair e2e test to delete check consider flag as block * ADM-898:[backend] fix: sonar issue * [ADM-877][frontend]: feat: remove the limit of start-date & end-date selection. (#1342) * [ADM-877][frontend]: feat: remove the limit of start-date & end-date selection. * [ADM-877][frontend]: chore: refine code. * ADM-873:[frontend][backend] fix: fix success notification (#1327) * ADM-873-bug:[docx] docx: fix docx * ADM-873:[frontend]fix: fix error notification * ADM-873:[frontend]refactor: refactor code * ADM-873-bug:[backend] feat: return flag for whether it has file create by this invoke * Revert "ADM-873:[frontend]refactor: refactor code" This reverts commit e2fe52f. * Revert "ADM-873:[frontend]fix: fix error notification" This reverts commit b659c63. * ADM-873:[frontend]fix: use hasCsvFileCreateSuccessful to handle success notification * ADM-873-bug:[backend] feat: return has csv create successful when get completed * ADM-873-bug:[backend] fix: rename * ADM-873:[frontend]fix: fix test * ADM-873:[frontend]refactor: rename hasCsvFileCreateSuccessful to isSuccessfulCreateCsvFile * ADM-873:[backend]refactor: modify test info * ADM-873:[backend]refactor: format code --------- Co-authored-by: yulongcai <[email protected]> Co-authored-by: Rui7ing <[email protected]> * [frontend] feat/adm 811: Do not clear the configuration settings when returning from the metric page to the configuration page. (#1343) * [feat][adm-811]: remove GoCD option * [frontend][adm-811]: feat: remove clear config data trigger when back to config page * [frontend][adm-811]: refact: refact unit test * [frontend][adm-811]: replace fireEvent use userEvent * [frontend][adm-811]: fix failed case * Adm 910[docs] feat: add Github graghQL rate limit issue (#1348) * ADM-910[docs] feat: add Node and Rate limits and calculate * ADM-910[docs] feat: add flew chart for get data by github api * Adm 912[frontend]: ui refine date picker in metrics page (#1349) * ADM-912 feat: display date ranges * ADM-912 test: add unit test * ADM-912 fix: fix css * ADM-912 fix: fix color * ADM-912 fix: fix hex color * ADM-912 fix: use color from theme * ADM-898:[frontend]feat: add block case * ADM-898:[frontend]fix: fix test for treatFlagCardAsBlock * ADM-898:[frontend]fix: fix bug * ADM-898 fix: fix treat flag card as block when import * ADM-898 fix: fix treat flag card as block when create * ADM-898 refactor: rename * ADM-898:[frontend]fix: remove unnecessary cycleTimeSettings * ADM-898 fix: fix test * ADM-898:[backend] refactor: refactor code * ADM-898 test: add unit test * ADM-898 test: add e2e test for no block column board when create project * ADM-898 test: add e2e test for no block column board when import project * ADM-898:[frontend]refactor: iterate over test data and run tests using forEach * ADM-898:[frontend]refactor: export BLOCK_COLUMN_NAME * ADM-898:[frontend]refactor: fix prettier error * ADM-898:[frontend]fix: fix the error from merge --------- Co-authored-by: Tingyu Dong <[email protected]> Co-authored-by: Steveay <[email protected]> Co-authored-by: PengxiWPix <[email protected]> Co-authored-by: guzhongren <[email protected]> Co-authored-by: YaoZhang87 <[email protected]> Co-authored-by: YaoZhang-Daniel <[email protected]> Co-authored-by: Chao <[email protected]> Co-authored-by: TingyuDong <[email protected]> Co-authored-by: Rui7ing <[email protected]> Co-authored-by: K Chow <[email protected]> Co-authored-by: junbo dai <[email protected]> Co-authored-by: Leiqiuhong <[email protected]> Co-authored-by: Leiqiuhong <[email protected]>
… page and add foru column in csv (#1361) * ADM-919:[backend] feat: Speed up the generating of pipeline data in report page * ADM-919:[backend] feat: fix e2e test * fix(e2e): fix env * Adm 920[backend] feat: Support to retrieve multiple pages of pipelines in metrics page (#1359) * ADM-920:[backend] feat: can get all pipeline info * ADM-920:[backend] fix: change Cache type * ADM-873:[frontend]fix: fix notification logic (#1356) Co-authored-by: yulongcai <[email protected]> * ADM-898[backend][frontend]: feat: block' in board mapping is mutually exclusive with 'flag as block' (#1350) * ADM-898:[backend] feat: should not export cycle time flag on table header when not consider flag as block * ADM-898:[frontend]feat: not show flagCard when board mapping table has ‘block’ column * ADM-898:[frontend]feat: warning pop-up when conflict * ADM-898:[frontend]refactor: refactor codes * ADM-898:[frontend]refactor: remove fromFlag * ADM-898:[frontend]feat: not show flagCard when board mapping table has ‘block’ column * ADM-873-bug:[backend] feat: add test for as flag is block is false * ADM-898:[frontend]feat: add status logic * ADM-898:[frontend]refactor: refactor code * ADM-898:[backend] fix: fix bug for not calculate flag block to cycle when consider flag as block * ADM-886:[docs]docs: refactor chart API docs sequence diagram (#1339) * ADM-886:[docs]docs: update chart API image size * ADM-886:[docs]docs: update chart API docs content * ADM-886:[docs]docs: refactor chart API docs * ADM-886:[docs]docs: refactor chart API docs sequence diagram * ADM 834 add frontend validation to board Id (#1338) * ADM-834:[frontend]feat: fix rebase * ADM-834:[backend]feat: added api for domain url check * ADM-834:[backend]feat: add dashboard api for site check * ADM-834:[backend]feat: added api for domain url check * ADM-834:[frontend]fix: fix rebase * ADM-834:[frontend]fix: add regex validation to board id * ADM-834:[frontend]fix: fix lint * ADM 751 [docs]docs: fix readme in board mappings part (#1334) * ADM-751:[frontend]feat: add by status e2e test flow into import test * ADM-751:[frontend]feat: add more flow in create test * ADM-751:[frontend]feat: fix lint and refactor fixture file * ADM-751:[frontend]feat: fix by state flow and add new test * ADM-751:[frontend]feat: refactored file strcture and implemented new e2e test for cycle time status testing, just need to fix the data then * ADM-751:[frontend]feat: rework the by status flow e2e test, remove unnecessary steps * ADM-751:[frontend]feat: fix test flow again * ADM-751:[frontend]feat: fix type check * ADM-751:[frontend]feat: add status flow e2e test in import test * ADM-751:[frontend]fix: fix lint * ADM-882:[backend]feat: add import json file * ADM-751:[frontend]fix: refactor code * ADM-751:[frontend]fix: refactor code fix type * ADM-751:[docs]docs: fix readme in board mappings * ADM-751:[docs]docs: remove conflicted rework part * ADM-751 refactor --------- Co-authored-by: guzhongren <[email protected]> * chore(sbom): generate sbom when releasing (#1340) * ADM-833:[frontend]feat:add e2e unhappy path scenarios (#1328) * ADM-833:[frontend]feat:add e2e unhappy path scenarios ADM-833: [frontend] add e2e test scenarios ADM-833: [frontend] fix: fix code style error ADM-833: [frontend] feat: add unhappy path scenoria ADM-833: [frontend] feat: optimize add and remove new pipeline,add unhappy path template ADM-833: [frontend] feat: optimize remove new pipeline,unhappy path template ADM-833: [frontend] feat: optimize remove new pipeline,unhappy path template ADM-833:[frontend]feat:merge unhappy path scenario ADM-833: [frontend] update: update e2e test scenarios ADM-833: [frontend] fix: fix code style error ADM-833: [frontend] update: update e2e test scenarios ADM-833: [frontend] update: update e2e test scenarios ADM-833: [frontend] fix: fix e2e test error ADM-833:[frontend]feat:distinguish major and unhappy path test in local environment ADM-833: [frontend] feat: sperate major and all ADM-833[frontend]feat:change branch invalid error message ADM-833: [frontend] fix: fix index.ts error ADM-833: [frontend] fix: remove the log file ADM-833: [frontend] fix: fix conflict with main branch ADM-833: [frontend] fix: revert readme ADM-833: [frontend] fix: remove log file ADM-833: [frontend] fix: modify .gitignore, add omit logs * ADM-833 fix path * ADM-833: [frontend] fix: update the spec location * ADM-833: [frontend] fix: fix daterange error * ADM-833: [frontend] fix: fix review error * ADM-833: [frontend] fix: fix review error --------- Co-authored-by: YaoZhang-Daniel <[email protected]> Co-authored-by: guzhongren <[email protected]> * ADM-833: [frontend] fix: fix env error (#1341) * ADM-833:[frontend]feat:add e2e unhappy path scenarios ADM-833: [frontend] add e2e test scenarios ADM-833: [frontend] fix: fix code style error ADM-833: [frontend] feat: add unhappy path scenoria ADM-833: [frontend] feat: optimize add and remove new pipeline,add unhappy path template ADM-833: [frontend] feat: optimize remove new pipeline,unhappy path template ADM-833: [frontend] feat: optimize remove new pipeline,unhappy path template ADM-833:[frontend]feat:merge unhappy path scenario ADM-833: [frontend] update: update e2e test scenarios ADM-833: [frontend] fix: fix code style error ADM-833: [frontend] update: update e2e test scenarios ADM-833: [frontend] update: update e2e test scenarios ADM-833: [frontend] fix: fix e2e test error ADM-833:[frontend]feat:distinguish major and unhappy path test in local environment ADM-833: [frontend] feat: sperate major and all ADM-833[frontend]feat:change branch invalid error message ADM-833: [frontend] fix: fix index.ts error ADM-833: [frontend] fix: remove the log file ADM-833: [frontend] fix: fix conflict with main branch ADM-833: [frontend] fix: revert readme ADM-833: [frontend] fix: remove log file ADM-833: [frontend] fix: modify .gitignore, add omit logs * ADM-833 fix path * ADM-833: [frontend] fix: update the spec location * ADM-833: [frontend] fix: fix daterange error * ADM-833: [frontend] fix: fix review error * ADM-833: [frontend] fix: fix review error * ADM-833: [frontend] fix: fix env error --------- Co-authored-by: YaoZhang-Daniel <[email protected]> Co-authored-by: guzhongren <[email protected]> * Revert "ADM-833: [frontend] fix: fix env error (#1341)" (#1344) This reverts commit eed90dc. * [ADM-833][frontend]: chore: fix the e2e env injection error. (#1345) * refactor(e2e): name conversion[frontend] * fix(e2e): fix type check[frontend] * ADM-898:[frontend]fix: fix test * ADM-898:[frontend]feat: add test for CycleTime * ADM-898:[frontend]fix: fix UpperCase error * ADM-898:[frontend]fix: fix default value * ADM-898:[frontend]fix: fix import treatFlagCardAsBlock value * ADM-898:[backend] fix: repair e2e test * ADM-898:[backend] fix: repair e2e test to delete check consider flag as block * ADM-898:[backend] fix: sonar issue * [ADM-877][frontend]: feat: remove the limit of start-date & end-date selection. (#1342) * [ADM-877][frontend]: feat: remove the limit of start-date & end-date selection. * [ADM-877][frontend]: chore: refine code. * ADM-873:[frontend][backend] fix: fix success notification (#1327) * ADM-873-bug:[docx] docx: fix docx * ADM-873:[frontend]fix: fix error notification * ADM-873:[frontend]refactor: refactor code * ADM-873-bug:[backend] feat: return flag for whether it has file create by this invoke * Revert "ADM-873:[frontend]refactor: refactor code" This reverts commit e2fe52f. * Revert "ADM-873:[frontend]fix: fix error notification" This reverts commit b659c63. * ADM-873:[frontend]fix: use hasCsvFileCreateSuccessful to handle success notification * ADM-873-bug:[backend] feat: return has csv create successful when get completed * ADM-873-bug:[backend] fix: rename * ADM-873:[frontend]fix: fix test * ADM-873:[frontend]refactor: rename hasCsvFileCreateSuccessful to isSuccessfulCreateCsvFile * ADM-873:[backend]refactor: modify test info * ADM-873:[backend]refactor: format code --------- Co-authored-by: yulongcai <[email protected]> Co-authored-by: Rui7ing <[email protected]> * [frontend] feat/adm 811: Do not clear the configuration settings when returning from the metric page to the configuration page. (#1343) * [feat][adm-811]: remove GoCD option * [frontend][adm-811]: feat: remove clear config data trigger when back to config page * [frontend][adm-811]: refact: refact unit test * [frontend][adm-811]: replace fireEvent use userEvent * [frontend][adm-811]: fix failed case * Adm 910[docs] feat: add Github graghQL rate limit issue (#1348) * ADM-910[docs] feat: add Node and Rate limits and calculate * ADM-910[docs] feat: add flew chart for get data by github api * Adm 912[frontend]: ui refine date picker in metrics page (#1349) * ADM-912 feat: display date ranges * ADM-912 test: add unit test * ADM-912 fix: fix css * ADM-912 fix: fix color * ADM-912 fix: fix hex color * ADM-912 fix: use color from theme * ADM-898:[frontend]feat: add block case * ADM-898:[frontend]fix: fix test for treatFlagCardAsBlock * ADM-898:[frontend]fix: fix bug * ADM-898 fix: fix treat flag card as block when import * ADM-898 fix: fix treat flag card as block when create * ADM-898 refactor: rename * ADM-898:[frontend]fix: remove unnecessary cycleTimeSettings * ADM-898 fix: fix test * ADM-898:[backend] refactor: refactor code * ADM-898 test: add unit test * ADM-898 test: add e2e test for no block column board when create project * ADM-898 test: add e2e test for no block column board when import project * ADM-898:[frontend]refactor: iterate over test data and run tests using forEach * ADM-898:[frontend]refactor: export BLOCK_COLUMN_NAME * ADM-898:[frontend]refactor: fix prettier error * ADM-898:[frontend]fix: fix the error from merge --------- Co-authored-by: Tingyu Dong <[email protected]> Co-authored-by: Steveay <[email protected]> Co-authored-by: PengxiWPix <[email protected]> Co-authored-by: guzhongren <[email protected]> Co-authored-by: YaoZhang87 <[email protected]> Co-authored-by: YaoZhang-Daniel <[email protected]> Co-authored-by: Chao <[email protected]> Co-authored-by: TingyuDong <[email protected]> Co-authored-by: Rui7ing <[email protected]> Co-authored-by: K Chow <[email protected]> Co-authored-by: junbo dai <[email protected]> Co-authored-by: Leiqiuhong <[email protected]> Co-authored-by: Leiqiuhong <[email protected]> * ADM-919:[backend] feat: add revert column in csv * ADM-919:[backend] feat: add job start time and pipeline start time and no pr commit time in csv * ADM-919:[backend] feat: fix e2e expect csv * ADM-919:[backend] feat: fix sonar error * ADM-919:[backend] fix: delete no use code * ADM-919:[backend] fix: add test for when build kite data info have author * ADM-919:[backend] fix: fix sonar error for eq * ADM-919:[backend] fix: update check error * ADM-919:[backend] fix: repair sonar issue * ADM-919:[backend] fix: format code * ADM-919:[backend] fix: add Nullable for field --------- Co-authored-by: guzhongren <[email protected]> Co-authored-by: junbo dai <[email protected]> Co-authored-by: TingyuDong <[email protected]> Co-authored-by: Tingyu Dong <[email protected]> Co-authored-by: Steveay <[email protected]> Co-authored-by: PengxiWPix <[email protected]> Co-authored-by: YaoZhang87 <[email protected]> Co-authored-by: YaoZhang-Daniel <[email protected]> Co-authored-by: Chao <[email protected]> Co-authored-by: Rui7ing <[email protected]> Co-authored-by: K Chow <[email protected]> Co-authored-by: Leiqiuhong <[email protected]> Co-authored-by: Leiqiuhong <[email protected]>
|
Hi @TingyuDong! 👋 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
...
Before
Description
Screenshots
If applicable, add screenshots to help explain behavior of your code.
After
Description
Screenshots
If applicable, add screenshots to help explain behavior of your code.
Note
Null