SCAL-222310 : Host Event Client #75
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sastaachar
force-pushed
the
SCAL-222310
branch
17 times, most recently
from
620fd42 to
75303a0
Compare
sastaachar
force-pushed
the
SCAL-222310
branch
from
797b124 to
f07c5fc
Compare
commit: |
Comment on lines
64
to
137
| if (hostEvent === HostEvent.Pin && payload?.newVizName) { | ||
| return this.handleUiPassthroughForHostEvent( | ||
| iFrame, UiPassthroughEvent.addVizToPinboard, payload, | ||
| ); | ||
| } | ||
| if (hostEvent === HostEvent.SaveAnswer && payload?.name) { | ||
| const data = await this.handleUiPassthroughForHostEvent( | ||
| iFrame, UiPassthroughEvent.saveAnswer, payload, | ||
| ); | ||
| return { | ||
| ...data, | ||
| answerId: data?.saveResponse?.data?.Answer__save?.answer?.id, | ||
| }; | ||
| } |
There was a problem hiding this comment.
Let's make this part more generic, so that it wouldn't be too hard when extending to new hostEvents
| return { ...response.value }; | ||
| } | ||
|
|
||
| public async hostEventFallback( |
There was a problem hiding this comment.
Move this up beside the executeUiPassthroughApi, to keep similar methods together and name them more similar with different intentions. eg executePassthroughEvent and executeHostEvent
utsavkapoor
approved these changes
Jan 8, 2025
…xnpm run lint -- --fix
sastaachar
force-pushed
the
SCAL-222310
branch
from
2db1147 to
922bcd3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.