Skip to content

Commit

Permalink
Merge pull request #22 from thoughtspot/update-rdme
Browse files Browse the repository at this point in the history
update readme note
  • Loading branch information
harshmeetTS authored Oct 10, 2024
2 parents f265b2f + 5b90332 commit 1c297fb
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions ReadMe.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,5 @@ We have introduced new folders for separate versions the folder structure apart
- If a minimum version required to run the chart is 10.5 the path to chart code is `src/v10_5/<customcharttype-folder>`
- We would need to update `sourceFolders` array in `vite.config.ts` for deployment.
- The generated urls will look like http://localhost:3002/v10_5/custom-bar-chart/ for TS version 10.5 where custom-bar-chart is the folder where custom bar chart code is present.

Note: Notice that we did not repeat the name of custom-bar-chart folder as it can cause conflicts while build how we have defined the current vite config so it is advised to use different folder names like the one we have used above.

0 comments on commit 1c297fb

Please sign in to comment.