Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow dependent modules to specify Grafana version #218

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

dickdavis
Copy link

@dickdavis dickdavis commented Dec 10, 2024

This PR provides dependent modules with the ability to specify a Grafana version to support in the workspace.

We (Three Ships/Home Solutions) would like to upgrade our Grafana version from 9.4.7 to the latest AWS-support Grafana version (10.4 according to the docs linked to above). Ideally, we'd like to upgrade to the latest version, but the resource does not appear to support that.

With this change, I believe we would just need to modify our module like so:

module "grafana_workspace" {
  providers = ...
  source    = "github.com/thoughtbot/flightdeck//aws/grafana-workspace?ref=10bd932" # change to point to this commit

  name = ...
  grafana_version = "10.4" # specify the latest supported version

  admin_groups = [
    ...
  ]

  editor_groups = [
    ...
  ]

  workload_account_ids = [
    ...
  ]
}

Please advise if this patch will achieve the outcome we are looking for. I'm a bit of a Terraform noob, so apologies if this patch is lacking; happy to make any necessary changes. Thanks!

Copy link
Contributor

@clarissalimab clarissalimab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From the documentation, it says that if no version is specified, then it defaults to the latest version, but since we're explicitly defaulting it to null, I wonder how the module will take that - I think it will work, but that might be a breaking change if we don't confirm that.

You can test if your change works as expected by changing the source to your local clone of the repo using a relative path or you can reference your branch. Let us know how that goes :)

Thank you for your contribution!

@dickdavis
Copy link
Author

From the documentation, it says that if no version is specified, then it defaults to the latest version, but since we're explicitly defaulting it to null, I wonder how the module will take that - I think it will work, but that might be a breaking change if we don't confirm that.

You can test if your change works as expected by changing the source to your local clone of the repo using a relative path or you can reference your branch. Let us know how that goes :)

Thank you for your contribution!

Just wanted to follow up with you to let you know this is still on my radar. Trying to work in some testing this week. Apologies for the delay!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants