Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove optional expo references #62

Merged
merged 4 commits into from
Oct 25, 2024
Merged

Conversation

katsuroo
Copy link
Contributor

Summary
This PR removes all code, documentation, and references related to supporting non-Expo applications. The CLI tool will now exclusively support Expo applications as per our previous decision.

Why this change?
As discussed, we have decided to simplify the tool and focus solely on Expo applications to reduce complexity and maintenance overhead.

This removes all the code and doc references for supporting non expo
projects
Copy link
Contributor

@codeofdiego codeofdiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this change. I just had a couple of commends on the .eta files, once those are addressed I believe this should be good to merge.

templates/testingLibrary/jest.config.js.eta Show resolved Hide resolved
templates/typescript/tsconfig.json.eta Show resolved Hide resolved
Copy link
Contributor

@codeofdiego codeofdiego left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@katsuroo katsuroo merged commit 559b040 into main Oct 25, 2024
2 checks passed
@katsuroo katsuroo deleted the jw/remove-non-expo-references branch October 25, 2024 04:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants