6 Usage Examples for JSON - Part 1 #331
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for splashkit-usage-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
EthanRin
suggested changes
Dec 11, 2024
There was a problem hiding this comment.
I've reviewed this PR and the implementation of each usage examples is clear and showcases each functions. Although there is some adjustments to be made:
- In the
free_jsonC# OOP example, there is a naming error at line 13 where it should be json rather than json1 to match the declared variable. - In the
json_from_colorC# Top Level example, I believe it should be COLOR_PURPLE() rather than COLOR_PURPLE at line 6. - I've looked at the text files and thought that maybe the function links to API pages could be capitalized to match the rest of the usage examples.
|
Made the changes, for |
EthanRin
approved these changes
Dec 15, 2024
There was a problem hiding this comment.
I've reviewed this usage example and have tested each implementation of the program across different languages.
The code is well-structured and is consistent throughout each implementations. I approved of this PR.
Checklist
- Code uses SplashKit functions
- Code demonstrates uses of the functions
- Python code ran as expected.
- C# OOP code ran as expected.
- C# Top Level code ran as expected
- C++ Code ran as expected
Files required
- Python code
- C# OOP code
- C# Top Level code
- C++ Code
- Screenshot of the program running
- Title and description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Created JSON functions for -
create_json,create_json_from_string,free_all_json,free_json,json_count_keys, andjson_from_color.These all show simple ways of using these functions all by creating a json object within the code and then doing the specific function.
Files Included (For all functions)
Usage Example Checks