Created simple usage examples for 5 Geometry functions #329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for splashkit-usage-examples ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
EthanRin
suggested changes
Dec 11, 2024
There was a problem hiding this comment.
I've reviewed this PR and the functions showcase in each usage example is great. Although there are some areas that can be improved on:
- The Color functions used in the C# OOP examples should use its OOP version. For example, the color red would be
Color.Redrather thanSplashKit.ColorRed(). - In the
lines_intersectexamples, the variable names could be improved on since each lines is represented by alphabets, the variables could also follow the same format. For instance, it would be startPointA rather than startPoint1 to provide clarity.
|
Hi @EthanRin, thanks for peer reviewing my PR. I've made the changes you've requested, kindly review. |
huyhuynh2319
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
I've reviewed the usage examples. Everything ran without issue.
Checks
- All required files are present.
- Title and explanation (.txt)
- C++ code
- C# code (top-level statements)
- C# code (Object-Oriented Programming)
- Python code
Tests done
- C++ code ran correctly.
- C# top level code ran correctly.
- C# OOP code ran correctly.
- Python code ran correctly.
EthanRin
approved these changes
Dec 12, 2024
There was a problem hiding this comment.
I've reviewed this usage example and have tested each implementation of the program across different languages.
The code is well-structured and is consistent throughout each implementations. I approved of this PR.
Checklist
- Code uses SplashKit functions
- Code demonstrates uses of the functions
- Python code ran as expected.
- C# OOP code ran as expected.
- C# Top Level code ran as expected
- C++ Code ran as expected
Files required
- Python code
- C# OOP code
- C# Top Level code
- C++ Code
- Screenshot of the program running
- Title and description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple geometry usage examples for line related functions
Splashkit Functions:
line_lengthline_length_squaredline_mid_pointline_to_stringlines_intersect