-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Initial implementation #1
base: main
Are you sure you want to change the base?
Conversation
- Add archive creation - Add gamelist generation
Also account for games in subdirectories
It doesn't compile as it depends on a weird json library
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is some really great work! I really like that you've used mechanisms which only rely on the standard Python libraries, keeping things simple and minimising dependencies.
The decoupling of the particular game configurations from the core code through using TOML files, is a fantastic way to ensure the project remains flexible and easier to maintain or expand.
Overall, this looks really good to me! There, obviously, is still a number of things to do, but I think this is a great foundation as it is. I've left one comment with an improvement that could be made to the README.
Additionally rename it to repo
This is more of a proof of concept then a fleshed out solution. Flipper will read in the toml files in the repository, compile the games and generate the necessary emulation station configuration. Then it creates a tarball which can then be extracted into the home directory of an arcade machine where all the configuration and such will be put in the correct locations.
Some glaring omissions is that this is yet to be tested with emulation station and that the github actions currently only compiles for amd64 linux. I tried to get cross compiling working for armhf (for the raspberry pi) and whilst C# games would be easy (and flipper has the functionality to cross compile C# games), for C++ games it would require one to cross compile splashkit and all it's dependencies. One possible solution would be to build splashkit on a raspberry pi then copy across the compiled library for use in github actions.