Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate/unit dates selector #271

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

XinHuang1112
Copy link

@XinHuang1112 XinHuang1112 commented Dec 23, 2024

Description

The unit-dates-selector component is a date selection tool for editing a unit's key details during the rollover process. It enables users to configure teaching periods, select start and end dates, and save the updated information for the unit.

Type of change

  • Bug fix
  • This change requires a documentation update

How Has This Been Tested?

Login in using avecnor user. Select a unit; click the drop down and choose Administration. Then choose unit details, and click teaching period, start date or end date.

I have tested this code by using the browser and have Screenshots will show comparison between previous and current implementation in various browsers.
#before:
unit-date-selector

#After:
1734956181009

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from @macite and @jakerenzella on the Pull Request

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants