Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Students-List component migrated #269

Open
wants to merge 3 commits into
base: development
Choose a base branch
from

Conversation

XinHuang1112
Copy link

@XinHuang1112 XinHuang1112 commented Dec 17, 2024

Description

The unit-details-editor component is responsible for displaying and managing a list of students within a unit. It allows instructors (Convenors, Tutors, Admins, and Auditors) to filter, sort, search, and view student details, manage pagination, export data, and interact with students' records.

Type of change

  • Bug fix
  • This change requires a documentation update

How Has This Been Tested?

Login in using avencor user. Select a unit; click the drop down and choose Students and view the component.

I have tested this code by using the browser and have Screenshots will show comparison between previous and current implementation in various browsers.
#before:
image

#After:
14018b5032f0779236da6f245d135b4

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from @macite and @jakerenzella on the Pull Request

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Once things are all working... you can delete the old CoffeeScript, HTML and SCSS files. These are no longer needed... so they can go!" as per the migration guide, this can be removed

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Once things are all working... you can delete the old CoffeeScript, HTML and SCSS files. These are no longer needed... so they can go!" as per the migration guide, this can also be removed

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, you have imported and used it.

Copy link

@nodogx nodogx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Once things are all working... you can delete the old CoffeeScript, HTML and SCSS files. These are no longer needed... so they can go!" as per the migration guide, this can also be removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants