-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rebase migration:grade-icon onto origin/8.0.x #259
base: 8.0.x
Are you sure you want to change the base?
rebase migration:grade-icon onto origin/8.0.x #259
Conversation
Please add the before and after screenshots to this PR. Include screenshots of all places where the grade-icon is used. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some mentions of grade-icon were not addressed. Double check this. You can search up all occurrences of 'grade-icon' in VS Code
src/app/tasks/modals/grade-task-modal/grade-task-modal.tpl.html
Outdated
Show resolved
Hide resolved
Thanks @satikaj , for the tasks, will target to finish them by EOD.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please include before screenshots as well
Good job! Can you please make a PR to the upstream (doubtfire-lms version of doubtfire-web)? |
Thanks @satikaj , here is the upstream PR link: doubtfire-lms#898 |
Description
The purpose of
grade-icon
is to provide a unified simple component, for displaying the grade student is expecting.Refer Documentation PR for Initial Information: thoth-tech/documentation#561
Refer Previous Declined PR (for dev branch.). This PR has been rebased to match with 8.0.x: #258
Fixes # (issue)
Type of change
How Has This Been Tested?
I have tested this code is working in browser and will be appending screenshots for the following to the Documentation PR.
Testing Checklist:
Checklist:
Screenshots Before Change:
students-list
portfolios:
group-member-contribution-assigner:
Student Group
Screenshots After Change:
students-list
portfolios:
group-member-contribution-assigner:
Student Group
Other Images