Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: update file,Unauthorised Component #257

Open
wants to merge 2 commits into
base: 8.0.x
Choose a base branch
from

Conversation

AusBruce
Copy link

@AusBruce AusBruce commented Sep 22, 2024

Description

This unauthorised component is about functionality that handles unauthorized access when a user attempts to interact with a service they do not have permission to access.

how to test it, first you can login as any user type, then in the url ,type http://localhost:4200/#/unauthorised
Or you can without login and type http://localhost:4200/#/unauthorised. The only different is it has select unit title.
This Pull Request is about migrate coffee script to Angular v17,
I have test before and after migration, there is no change related to the unauthorised icon.
Before migration screenshot:
image

After screenshot:
image

Fixes # (issue)

Type of change

  • Code Migration (non-breaking change)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from @macite and @jakerenzella on the Pull Request

@sylvia0929
Copy link

I have tested your unauthorised component, it looks like before and after are the same. you have specify the doubtfire.state file which show you have understood the logic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants