Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/pull remaining units #253

Open
wants to merge 15 commits into
base: development
Choose a base branch
from

Conversation

sammyrolfe
Copy link

Description

Pulled unit-definitions from dummy data in back end to populate 'required units' container.

Screenshot 2024-09-19 at 9 31 49 pm

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@sylvia0929
Copy link

Pulled unit definitions from dummy data to populate the 'required units' container.Tested on Chrome, Safari, and Firefox. Code follows project guidelines and no new warnings were generated.

@DudeUnleashed
Copy link

The unit definitions are being pulled to fill the required units section of the menu. At the moment the area floods when there are too many units visible, so a possible improvement for the future is to limit the view and add scroll bars, ect.
image

Otherwise, looks and functions good, code is commented where appropriate and follows standards.

@aNebula
Copy link

aNebula commented Oct 14, 2024

Good work this trimester @sammyrolfe - time to make your contributions 'lasting'.
Please open an upstream PR with these changes against new/course-flow branch on doubtfire-lms/doubtfire-web.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants