Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add csv-result-modal migrated #248

Open
wants to merge 4 commits into
base: development
Choose a base branch
from

Conversation

AnirudhNJ
Copy link

@AnirudhNJ AnirudhNJ commented Sep 15, 2024

Any italic text should be deleted from the final Pull Request text, including this line

Description

Migrated csv-result-modal.

Fixes # (issue)

Type of change

The component is working now as expected.
Before :
file-uploader2

After:
Screenshot 2024-09-14 at 9 30 03 PM

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have requested a review from @macite and @jakerenzella on the Pull Request

@b0ink
Copy link

b0ink commented Sep 20, 2024

Hi @AnirudhNJ

I attempted to import tasks using COS10001-Tasks.csv from doubtfire-api/test_files, it said it successfully imported the tasks, however the csv-result-modal did not pop up after the import, and no new tasks were created. Could you please look into this?

@AnirudhNJ
Copy link
Author

Hi, So the changes has been made and is fixed it should work now thanks.

@AmosSaji
Copy link

Hi Anirudh,
I had a look at the above commit and it looks like that the upload modal follows all the style guidelines. Good job.

@satikaj
Copy link
Collaborator

satikaj commented Oct 13, 2024

Still does not show the result screen. Before and after versions' functionality differs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants