-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Groupsetmanager/migration #244
base: development
Are you sure you want to change the base?
Changes from all commits
870b6e6
46cb669
94e2a52
9c9230b
42e90ac
1a47c73
90fe51e
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
This file was deleted.
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,59 @@ | ||
<!-- <group-selector | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why is this commented out? You should still be using group-selector. But that component would need to be migrated to Angular 17 first |
||
[unit]="unit" | ||
[unit-role]="unitRole" | ||
[project]="project" | ||
[selected-group]="selectedGroup" | ||
[selected-group-set]="selectedGroupSet" | ||
[show-group-set-selector]="showGroupSetSelector" | ||
(on-select)="newGroupSelected()" | ||
class="mat-card mat-card-primary" | ||
> --> | ||
<!-- </group-selector> --> | ||
|
||
<mat-card *ngIf="selectedGroup"> | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. ngIf and the like should not be used |
||
<mat-card-header> | ||
<mat-card-title> | ||
Members of | ||
<span *ngIf="unitRole || selectedGroupSet.allowStudentsToManageGroups"> | ||
<a (click)="updateGroup(selectedGroup)"> | ||
{{ selectedGroup.name }} | ||
</a> | ||
</span> | ||
</mat-card-title> | ||
<mat-card-subtitle> | ||
<mat-icon *ngIf="selectedGroup.locked" matTooltip="This group is locked">lock</mat-icon> | ||
</mat-card-subtitle> | ||
</mat-card-header> | ||
|
||
<mat-card-content *ngIf="showMemberPanelToolbar"> | ||
<form (ngSubmit)="addMember(selectedStudent)" class="input-group"> | ||
<mat-form-field> | ||
<input | ||
matInput | ||
placeholder="Enter student name or username..." | ||
[(ngModel)]="selectedStudent" | ||
name="selectedStudent" | ||
[matAutocomplete]="auto" | ||
(input)="filterStudents($event.target.value)" | ||
/> | ||
<mat-autocomplete #auto="matAutocomplete" (optionSelected)="addMember($event.option.value)"> | ||
<mat-option *ngFor="let student of filteredStudents | async" [value]="student"> | ||
{{ student.name }} | ||
</mat-option> | ||
</mat-autocomplete> | ||
</mat-form-field> | ||
|
||
<button mat-raised-button color="primary" type="submit" [disabled]="!selectedStudent.id"> | ||
<mat-icon>add</mat-icon> Add Member | ||
</button> | ||
</form> | ||
</mat-card-content> | ||
|
||
<group-member-list | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is still a AngularJS component so this would not work |
||
[unit]="unit" | ||
[unit-role]="unitRole" | ||
[project]="project" | ||
[selected-group]="selectedGroup" | ||
(on-members-loaded)="groupMembersLoaded()" | ||
></group-member-list> | ||
</mat-card> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should not have been updated