-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: upload files #231
base: development
Are you sure you want to change the base?
Conversation
The component is working fine and looks good on my end - I believe I encountered a similar issue to @sammyrolfe, but clearing the cache resolved this (most likely conflicts between One issue I noticed was that the tooltips weren't working as intended. To fix this you'll need to continue using However, there may now be an issue with both the old bootstrap |
Hi, I have recovery the tooltip="..." in *.tpl.html files. Can you review my PR again? Thuy Tien Hoa (223623149) |
The component is working in my local machine, and based on your changed file, I believe your have done the front-end migration, it is ready to put on upstream review! |
Hi, |
@tinahoa The old CoffeeScript, HTML and SCSS files needs to be deleted. |
@tinahoa please open a upstream PR against doubtfire-lms/doubtfire-web 9.x branch. |
Description
Migrates the grade-icon from CoffeeScript to TypeScript as a visual indicator for grading within the application. It provides a user interface for displaying a grade with an associated tooltip, making it easier for tutors to quickly assess and review student performance.
Before:
After:
Fixes # (issue)
Type of change
How Has This Been Tested?
Login as student and create portfolio
Select the target grade, the grade icon appears properly.
Login as tutor and select student list
The grade icon appears properly according to the student's target grade.
Testing Checklist:
Checklist: