refactor: replace fxLayout with tailwind equivalent - hero-sidebar component #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
BRIAN CALDERA will review this PR. |
BrianJCal99
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Hey @williamalowe, The code appears to be in correct format with no errors encountered during testing. The screenshots provided in the description look the sams as well. It is all good to be merged now @maddernd.
|
This one is good to go for upstream creation to doubtfire-lms |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replaced depreciated fxLayout library implemented with equivalent Tailwindcss for hero-sidebar component.
Type of change
How Has This Been Tested?
before:
after:
Testing Checklist:
Checklist: