Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace fx-layout with tailwind equivalent - unit-dropdown #108

Merged
merged 2 commits into from
Mar 5, 2024

Conversation

satikaj
Copy link
Collaborator

@satikaj satikaj commented Nov 23, 2023

Description

Replaced the fx-layout usage in the unit-dropdown component with the Tailwind equivalent due to the deprecation of the fx-layout library.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

  1. Run the doubtfire-deploy dev container to start the front-end and back-end.
  2. Login with the test student account (student_1).
  3. Click on the Select Unit dropdown to compare looks.

Before

before-student

After

after-student

Testing Checklist:

  • Tested in latest Chrome
  • Tested in latest Safari
  • Tested in latest Firefox

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings

@satikaj
Copy link
Collaborator Author

satikaj commented Nov 23, 2023

@williamalowe will be reviewing this.

@williamalowe
Copy link

Reviewed on 25/11/2023
-All fxLayout properties have been replaced with appropriate Tailwindcss equivalents.
-Changes does not throw any terminal errors.
-Before and After images are reproducible and appear identical.
-Inspection with browser dev tools shows exact same spacings.
Ready for second review

@maddernd
Copy link

I have also tested this,

Code looks good, runs correctly and looks correctly on my local build.

@maddernd
Copy link

This one is good to go for upstream creation to doubtfire-lms

@satikaj
Copy link
Collaborator Author

satikaj commented Dec 11, 2023

Upstream pull request has already been created doubtfire-lms#771

@maddernd maddernd merged commit af8f03e into thoth-tech:development Mar 5, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants