-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Panopto OAuth2 integration #48
base: 9.x
Are you sure you want to change the base?
Conversation
Signed-off-by: washyking <[email protected]>
Signed-off-by: washyking <[email protected]>
Signed-off-by: washyking <[email protected]>
Signed-off-by: washyking <[email protected]>
Signed-off-by: washyking <[email protected]>
Hi @washyking , I have verified your code locally and it is working as expected. This feature is really good addition to OnTrack as a whole. Approving this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @washyking i accessed the code locally and as stated its working properly by creating a API client with panopto and integrating with Ontrack. Great work Keep it up! Panopto Video Integration with Ontrack will become a great help for Future Students!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@washyking Why was the Gemfile.lock
and db/schema.rb
deleted? I think this needs to be fixed, otherwise it'll break the app.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
bundle install
on the branchYOUR_CLIENT_ID
andYOUR_CLIENT_SECRET
Checklist:
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
I have created or extended unit tests to address my new additions
New and existing unit tests pass locally with my changes
Any dependent changes have been merged and published in downstream modules
If you have any questions, please contact @macite or @jakerenzella.