-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Adding Teacher Comment Mailer #46
base: 8.0.x
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Shounaks Good work! The code keeps the logic for sending within the mailer. Perfectly have used rescue to handle mailing errors and logging them. The Html and the Text templates both provide a good user experience.
Spelling errors of received,
Double check to ensure if the mailer methods are needed to be added. @tasks, @tutor, @hasComments
and also to double check the variable "(@hasComments vs. @has_comments)"
I removed those, since, they are not required in my context. 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code has been reviewed and it is running successfully, as confirmed by the logs showing "Sending comment notification email for project 33." While the ApplicationMailer doesn't have local access, everything else is working as intended for me. The code looks well-implemented great job! @Shounaks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.
Fixes # (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist:
If you have any questions, please contact @macite or @jakerenzella.