Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Adding Teacher Comment Mailer #46

Open
wants to merge 2 commits into
base: 8.0.x
Choose a base branch
from

Conversation

Shounaks
Copy link

@Shounaks Shounaks commented Nov 29, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test A
  • Test B

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation if appropriate
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have created or extended unit tests to address my new additions
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

If you have any questions, please contact @macite or @jakerenzella.

@Shounaks Shounaks changed the title Adding Teacher Comment Mailer Feat/Adding Teacher Comment Mailer Nov 29, 2024
@Shounaks
Copy link
Author

Shounaks commented Dec 2, 2024

image
Email Sent Console log notification.

app/models/task.rb Outdated Show resolved Hide resolved
app/models/task.rb Outdated Show resolved Hide resolved
Copy link

@nodogx nodogx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shounaks Good work! The code keeps the logic for sending within the mailer. Perfectly have used rescue to handle mailing errors and logging them. The Html and the Text templates both provide a good user experience.

Spelling errors of received,
Double check to ensure if the mailer methods are needed to be added. @tasks, @tutor, @hasComments and also to double check the variable "(@hasComments vs. @has_comments)"

@Shounaks
Copy link
Author

Shounaks commented Dec 8, 2024

@Shounaks Good work! The code keeps the logic for sending within the mailer. Perfectly have used rescue to handle mailing errors and logging them. The Html and the Text templates both provide a good user experience.

Spelling errors of received, Double check to ensure if the mailer methods are needed to be added. @tasks, @tutor, @hasComments and also to double check the variable "(@hasComments vs. @has_comments)"

I removed those, since, they are not required in my context. 👍

Copy link

@Ashdeore Ashdeore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new

The code has been reviewed and it is running successfully, as confirmed by the logs showing "Sending comment notification email for project 33." While the ApplicationMailer doesn't have local access, everything else is working as intended for me. The code looks well-implemented great job! @Shounaks

Copy link

@s223552468 s223552468 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2024-12-11 132048
Approved. As shown in the screenshot, the initiation for sending email notifications has started successfully. I have reviewed the code, and it works as required, though the local access to ApplicationMailer is still unavailable. Great job!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants