-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: added target grade change history feature #44
base: development
Are you sure you want to change the base?
feat: added target grade change history feature #44
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Hi @Shounaks - please follow the PR review guide here https://thoth-tech.netlify.app/products/splashkit/splashkit-website/onboarding/05-peer-review/ (Point 1-3 are splashkit specific, but the rest of the guide should apply to OnTrack as well.) In your review, you have to be more detailed than that - comment on what you looked at, what you checked, whether you cloned this and ran this (you must) and code quality and formatting etc. Please review this again. |
I am happy for a non-paginated backend api to be merged in this PR, as I've created a separate task for implementing backend pagination on the board. |
I am happy with your pull request if thats the case Jude good work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
project.target_grade = new_grade | ||
|
||
if project.save | ||
# Record the grade change history |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Like you commented the creation of target_grade_histories. Comments of what the attributes mean
@nodogx If you have done API Integration testing, as mentioned in the description, why not include them with the code? Please include tests, and then I'll review again. |
Description
This PR introduces a new Target Grade Change History feature on the front end and the back end. The feature includes:
• A new table in the Progress Dashboard to display the history of changes made to a student’s target grade.
• Integration with the back-end API to fetch and render the target grade history dynamically.
• Relevant CoffeeScript and HTML updates to ensure seamless functionality and responsiveness.
Type of change
How Has This Been Tested?
The changes were tested as follows:
• Verified that the Target Grade Change History table renders correctly on the Progress Dashboard.
• Ensured responsive layout across devices.
• Confirmed data is fetched correctly from the back end and rendered in the front end.
• Tested error handling for scenarios like no data or failed API calls.
Testing Checklist:
Checklist:
Front end Pull Request -- thoth-tech/doubtfire-web#262