Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge commits from the task-similarity branch from upstream #18

Merged
merged 13 commits into from
Mar 27, 2024

Conversation

ublefo
Copy link
Collaborator

@ublefo ublefo commented Mar 26, 2024

Merge some commits from https://github.com/doubtfire-lms/doubtfire-api/commits/new/task-similarity/ . These commits contain the necessary fixes on the TII related components to get unit tests all working again. These fixes are mandatory for us to have a good stable base to work on top of, and enable us to be able to test our work.

Instruction for reviewers: checkout the branch locally, run unit tests and make sure there are no errors.

@satikaj
Copy link
Collaborator

satikaj commented Mar 26, 2024

This is good to be merged. I've run unit tests and they are all working fine now. @maddernd

@ublefo ublefo mentioned this pull request Mar 26, 2024
@maddernd maddernd merged commit 1e52ea5 into thoth-tech:development Mar 27, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants