-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: store Numbas config in backend #16
feat: store Numbas config in backend #16
Conversation
c4ef3f6
to
92b86ea
Compare
Rubocop offenses are fixed as well
92b86ea
to
a65580d
Compare
|
app/api/task_definitions_api.rb
Outdated
@@ -28,6 +28,9 @@ class TaskDefinitionsApi < Grape::API | |||
optional :upload_requirements, type: String, desc: 'Task file upload requirements' | |||
optional :plagiarism_checks, type: String, desc: 'The list of checks to perform' | |||
requires :plagiarism_warn_pct, type: Integer, desc: 'The percent at which to record and warn about plagiarism' | |||
requires :has_enabled_numbas_test, type: Boolean, desc: 'Whether or not Numbas test assessment is enabled for this task' | |||
requires :numbas_time_delay, type: String, desc: 'The time delay between Numbas test attempts' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we change this time delay to an integer (in minutes) as well?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Daniel plans to have an incremental delay feature which the tutor can enable. So first 2 attempts would have no delay, the next would have a 30 min delay, then 2 hours, and so on until the student has to see the tutor. I've modified the code to accomodate this already.
Description
The backend schema and files for task definition were updated to store Numbas config options.
Type of change
How Has This Been Tested?
This was tested with the frontend task editor UI. Upon uploading and configuring Numbas tests, the state is saved even after refreshing the page.
Checklist: