This repository has been archived by the owner on Feb 14, 2019. It is now read-only.
Use separate DN for nested groups, add option not to create such groups #207
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If subgroups are under different DN (comparing to main groups), the plugin fails to fetch them.
nilas 'Groups base DN' doesn't help here either.So, in this fork I solved this issue (#205) by:
Regarding the latter:
The plugin always creates all groups, the user belongs to. But, when importing users, who belong to subgroups, we may not want such groups to be imported (such users are also added to the corresponding main group). Therefore, I added 'Create nested groups', that allows to control this.
Thanks @acosonic for the idea.