Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more steps into the README #2

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

nenkoru
Copy link

@nenkoru nenkoru commented Mar 19, 2023

Spent some time figuring out how to run the project. There are steps missing which I added into the README

thomasantony and others added 2 commits March 18, 2023 19:34
Make torch an optional dependency and fix the CI workflows
@thomasantony
Copy link
Owner

thomasantony commented Mar 19, 2023

Thanks for the PR. I have actually made some changes to how the package is built as there were some limitations to using poetry. Please take a look and update your comments.

Also, I would like to keep the commit history linear. Please use rebase instead of using merge commits in your branch.

You should be able to do git rebase -i master and then fix any merge conflicts and drop the merge commit that was added.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants