Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use Flint* globals #1674

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Merge branch 'master' into lg/excise-Flint-globals

77fcb3a
Select commit
Loading
Failed to load commit list.
Open

Don't use Flint* globals #1674

Merge branch 'master' into lg/excise-Flint-globals
77fcb3a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Nov 8, 2024 in 0s

75.98% (+0.00%) compared to 39fc9cb

View this Pull Request on Codecov

75.98% (+0.00%) compared to 39fc9cb

Details

Codecov Report

Attention: Patch coverage is 75.77465% with 258 lines in your changes missing coverage. Please review.

Project coverage is 75.98%. Comparing base (39fc9cb) to head (77fcb3a).

Files with missing lines Patch % Lines
src/NumField/NfAbs/NormRelation/Setup.jl 19.23% 21 Missing ⚠️
src/AlgAssAbsOrd/PIP/bley_hofmann_johnston.jl 0.00% 11 Missing ⚠️
src/EllCrv/Misc.jl 10.00% 9 Missing ⚠️
src/Misc/nmod_poly.jl 57.14% 9 Missing ⚠️
src/NumFieldOrd/NfOrd/LinearAlgebra.jl 18.18% 9 Missing ⚠️
src/AlgAssAbsOrd/Order.jl 60.00% 8 Missing ⚠️
src/EllCrv/LocalData.jl 88.33% 7 Missing ⚠️
src/Misc/RatRecon.jl 0.00% 7 Missing ⚠️
ext/PolymakeExt.jl 33.33% 6 Missing ⚠️
src/AlgAssAbsOrd/PIP/maximal.jl 40.00% 6 Missing ⚠️
... and 83 more
Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1674   +/-   ##
=======================================
  Coverage   75.97%   75.98%           
=======================================
  Files         361      361           
  Lines      113876   113877    +1     
=======================================
+ Hits        86518    86529   +11     
+ Misses      27358    27348   -10     
Files with missing lines Coverage Δ
ext/GAPExt/abelian_layer.jl 91.22% <100.00%> (ø)
ext/GAPExt/brauer.jl 74.41% <100.00%> (ø)
src/AlgAss/AbsAlgAss.jl 90.16% <100.00%> (ø)
src/AlgAss/AlgQuat.jl 90.71% <100.00%> (ø)
src/AlgAss/ChangeRing.jl 94.06% <ø> (ø)
src/AlgAss/Conversions.jl 82.03% <100.00%> (ø)
src/AlgAss/Elem.jl 88.17% <100.00%> (ø)
src/AlgAss/StructureConstantAlgebra.jl 93.63% <100.00%> (ø)
src/AlgAss/radical.jl 94.78% <100.00%> (ø)
src/AlgAssAbsOrd/LocallyFreeClassGroup.jl 92.47% <100.00%> (ø)
... and 160 more

... and 10 files with indirect coverage changes