Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add mutating arithmetic for SRows #1659

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Add mutating arithmetic for SRows #1659

wants to merge 9 commits into from
+204 −20

Commits on Oct 25, 2024

  1. Make scale_row! follow its docstring 

    i.e. don't throw on zero scalars, and coerce scalars if needed
    @lgoettgens
    lgoettgens committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    5d974b1 View commit details
    Browse the repository at this point in the history

  2. Fix a docstring typo

    @lgoettgens
    lgoettgens committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    1c06d6e View commit details
    Browse the repository at this point in the history

  3. Let add_scaled_row coerce the scalar

    @lgoettgens
    lgoettgens committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    67da91f View commit details
    Browse the repository at this point in the history

  4. Add mutating arithmetics for SRow

    @lgoettgens
    lgoettgens committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    ea21c55 View commit details
    Browse the repository at this point in the history

  5. Skip deepcopy in addmul! in case of aliasing

    @lgoettgens
    lgoettgens committed Oct 25, 2024
    Configuration menu
    Copy the full SHA
    9ddf26e View commit details
    Browse the repository at this point in the history

Commits on Nov 5, 2024

  1. Add submul!

    @lgoettgens
    lgoettgens committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    94b188a View commit details
    Browse the repository at this point in the history

  2. Add tests

    @lgoettgens
    lgoettgens committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    9975911 View commit details
    Browse the repository at this point in the history

  3. Some fixes (tests run now)

    @lgoettgens
    lgoettgens committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    0057c19 View commit details
    Browse the repository at this point in the history

  4. Comment out tests

    @lgoettgens
    lgoettgens committed Nov 5, 2024
    Configuration menu
    Copy the full SHA
    c5fb659 View commit details
    Browse the repository at this point in the history