Turn FinGenAbGroupElem
into a non-mutable struct
#1621
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reduce allocations and increases speed of code using these elements.
Using the same example as in oscar-system/Oscar.jl#4119, we get the following.
Before this PR here:
With just this PR:
With just oscar-system/Oscar.jl#4119:
With this PR and oscar-system/Oscar.jl#4119:
So allocations are further reduced but performance stays the same. But that's OK because in that example only relatively few
FinGenAbGroupElem
are used after oscar-system/Oscar.jl#4119 ; but many other places still use them extensively, so it still seems quite useful to me to have this.