Support vars sourcing, passing raw ssh/docker opts, prerun vars expansion #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sion This commit adds the ability to expand bash variables before spec execution (default is during execution on the target host) and optionally source a variable file to use during expansion. This commit also adds the ability to pass raw SSH/docker options to the commands. Additional bug fixes include docker container checking and support '--help' flag. Closes #2
nextrevision
force-pushed
the
feature/vars-expansion-raw-opts
branch
from
25a40cd to
1bd023f
Compare
|
There's a lot going on in this PR. The -o and --help are relatively minor, but deserve to be in their own commit, if not their own PR. For the -e/-f, it looks to be an all or nothing thing. It's not possible to sub in local vars and still leverage any remote env variables. What's the current use case for this feature? |
nextrevision
force-pushed
the
feature/vars-expansion-raw-opts
branch
from
a39f170 to
e31f442
Compare
cllunsford
added a commit
that referenced
this pull request
Aug 6, 2015
Support vars sourcing, passing raw ssh/docker opts, prerun vars expansion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the ability to expand bash variables before spec
execution (default is during execution on the target host) and
optionally source a variable file to use during expansion. This commit
also adds the ability to pass raw SSH/docker options to the commands.
Additional bug fixes include docker container checking and support '--help'
flag.
Closes #2