Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[express-apollo-prisma] Final cleanup from demo feedback #1207

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

[express-apollo-prisma] Final cleanup from demo feedback #1207

wants to merge 19 commits into from

Conversation

iansamz
Copy link
Contributor

@iansamz iansamz commented Mar 27, 2023 •
edited
Loading

Type of change

  • Documentation change
  • Bug fix

Summary of change

  • GraphQL naming conventions
  • Update README and link to accompanying blog post explaining limitations (Will be updated when blog is ready)
  • Clean up the scripts (yarn start, yarn test etc)
  • Fix linting issues (exclude .yaml files)
  • .env globally available with running queue (optional)

Checklist

@iansamz iansamz requested a review from mbicknese March 27, 2023 12:09
@netlify
Copy link

netlify bot commented Mar 27, 2023 •
edited
Loading

✅ Deploy Preview for starter-dev canceled.

Name Link
🔨 Latest commit 414255a
🔍 Latest deploy log https://app.netlify.com/sites/starter-dev/deploys/642c3023ddc2af0008473d9c

@mbicknese
Copy link
Contributor

starter.dev/starters/express-apollo-prisma/src/graphql/mappers/technology.ts

Line 18 in 314dab5

items: entityCollectionPage.items.map(mapTechnology),

Still refers to items

mbicknese
mbicknese suggested changes Mar 30, 2023
View reviewed changes
Copy link
Contributor

@mbicknese mbicknese left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried to work on this branch, but there are more changes required throughout the code to make the new types work. Can you do a sweep to find all outdated code?

@iansamz iansamz self-assigned this Apr 4, 2023
@sonarcloud
Copy link

sonarcloud bot commented Apr 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

ihardz
ihardz approved these changes May 26, 2023
View reviewed changes
Copy link
Contributor

@ihardz ihardz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iansamz , resolve conflicts and merge. Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vyktoremario vyktoremario vyktoremario approved these changes

@ihardz ihardz ihardz approved these changes

@kodejuice kodejuice kodejuice approved these changes

@mbicknese mbicknese mbicknese approved these changes

Assignees

@iansamz iansamz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[express-apollo-prisma] Final cleanup from demo feedback
5 participants
@iansamz @mbicknese @kodejuice @ihardz @vyktoremario