Skip to content

Commit

Permalink
Change "completely private" => "private" from in-app text (brave#24415)
Browse files Browse the repository at this point in the history
Rm "completely private" from in-app text
  • Loading branch information
ShivanKaul authored Jun 28, 2024
1 parent 18f68bd commit 0b08de5
Show file tree
Hide file tree
Showing 6 changed files with 8 additions and 8 deletions.
6 changes: 3 additions & 3 deletions browser/ui/android/strings/android_brave_strings.grd
Original file line number Diff line number Diff line change
Expand Up @@ -597,13 +597,13 @@ This file contains all "about" strings. It is set to NOT be translated, in tran
Enabled
</message>
<message name="IDS_BRAVE_NEWS_OPTIN_TITLE" desc="Text for opt in card title">
Today’s top stories in a completely private feed, just for you.
Today’s top stories in a private feed, just for you.
</message>
<message name="IDS_BRAVE_NEWS_SETTINGS_OPTIN_TITLE" desc="Text for opt in card title in settings">
Turn on Brave News, and never miss a story
</message>
<message name="IDS_BRAVE_NEWS_OPTIN_SUBTITLE" desc="Text for opt in card subtitle">
Brave News is ad-supported with completely private and anonymized ads matched on your device.
Brave News is ad-supported with private and anonymized ads matched on your device.
</message>
<message name="IDS_BRAVE_NEWS_SETTINGS_OPTIN_SUBTITLE" desc="Text for opt in card subtitle in settings">
Follow your favorite sources, in a single feed. Just open a tab in Brave, scroll down, and... voila!\nBrave News is ad-supported with private, anonymized ads.
Expand Down Expand Up @@ -882,7 +882,7 @@ This file contains all "about" strings. It is set to NOT be translated, in tran
Send diagnostic reports if you experience a crash or freeze.
</message>
<message name="IDS_P3A_INSIGHTS" desc="Text for p3a insights onboarding">
Share completely private and anonymous product insights about what features are being used by Brave's users.
Share private and anonymous product insights about what features are being used by Brave's users.
</message>
<message name="IDS_TYPE_WEBSITE" desc="Text for searhbox tooltip title onboarding">
Type a website name or URL
Expand Down
2 changes: 1 addition & 1 deletion components/brave_welcome_ui/stories/locale.ts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ provideStrings({
braveWelcomeSelectAllButtonLabel: 'Select All',
braveWelcomeHelpImproveBraveTitle: 'Help make Brave better.',
braveWelcomeSendReportsLabel: 'Send diagnostic reports if you experience a crash or freeze. $1Learn more.$2',
braveWelcomeSendInsightsLabel: 'Share completely private and anonymous product insights about what features are being used by Brave\'s users. $1Learn more.$2',
braveWelcomeSendInsightsLabel: 'Share private and anonymous product insights about what features are being used by Brave\'s users. $1Learn more.$2',
braveWelcomeSetupCompleteLabel: 'Setup complete',
braveWelcomeChangeSettingsNote: ' Change these choices at any time in Brave at $1brave://settings/privacy$2.',
braveWelcomePrivacyPolicyNote: 'Read our full $1Privacy Policy$2',
Expand Down
2 changes: 1 addition & 1 deletion components/resources/brave_welcome_strings.grdp
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@
</message>

<message name="IDS_BRAVE_WELCOME_SEND_INSIGHTS_LABEL" desc="A checkbox label for user to opt-in opt-out to share anonymous, product insights information">
Share completely private and anonymous product insights about what features are being used by Brave's users. <ph name="LINK_BEFORE">$1</ph>Learn more.<ph name="LINK_AFTER">$2</ph>
Share private and anonymous product insights about what features are being used by Brave's users. <ph name="LINK_BEFORE">$1</ph>Learn more.<ph name="LINK_AFTER">$2</ph>
</message>

<message name="IDS_BRAVE_WELCOME_SETUP_COMPLETE_LABEL" desc="A title for screen when user has completed all the steps">
Expand Down
2 changes: 1 addition & 1 deletion ios/brave-ios/App/iOS/Delegates/SceneDelegate.swift
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ class SceneDelegate: UIResponder, UIWindowSceneDelegate {
// The reason p3a user consent is necesserray to call search ad install attribution API methods
if !Preferences.AppState.dailyUserPingAwaitingUserConsent.value {
// If P3A is not enabled, send the organic install code at daily pings which is BRV001
// User has not opted in to share completely private and anonymous product insights
// User has not opted in to share private and anonymous product insights
if AppState.shared.braveCore.p3aUtils.isP3AEnabled {
Task { @MainActor in
do {
Expand Down
2 changes: 1 addition & 1 deletion ios/brave-ios/Sources/BraveStrings/BraveStrings.swift
Original file line number Diff line number Diff line change
Expand Up @@ -795,7 +795,7 @@ extension Strings {
"callout.p3aCalloutToggleTitle",
tableName: "BraveShared",
bundle: .module,
value: "Share Completely Private and Anonymous Product Insights.",
value: "Share Private and Anonymous Product Insights.",
comment:
"Title for toggle for enabling p3a (Privacy Preserving Analytics) Full Screen Callout"
)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ extension Strings {
"focusOnboarding.p3aToggleTitle",
tableName: "FocusOnboarding",
bundle: .module,
value: "Share Completely Private & Anonymous Product Insights.",
value: "Share Private & Anonymous Product Insights.",
comment: "The title of the toggle for enable / disable the privacy preserving analytics."
)

Expand Down

0 comments on commit 0b08de5

Please sign in to comment.