[SDK] Fix: Remove and Prevent console.log
#5527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregfromstl
requested review from
joaquim-verges,
MananTank,
jnsdls and
edwardysun
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
jnsdls
approved these changes
Nov 26, 2024
size-limit report 📦
|
gregfromstl
added
the
merge-queue
Merge activity
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5527 +/- ##
==========================================
+ Coverage 46.18% 46.20% +0.01%
==========================================
Files 1083 1080 -3
Lines 58683 58569 -114
Branches 3936 3929 -7
==========================================
- Hits 27105 27060 -45
+ Misses 30895 30826 -69
Partials 683 683
*This pull request uses carry forward flags. Click here to find out more.
|
CNCT-2483 <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on removing `console.log` statements from various files to clean up the code and improve maintainability. It also modifies the linter configuration to adjust rules related to console usage. ### Detailed summary - Removed `console.log` statements from multiple test and implementation files. - Adjusted linter configuration to allow specific console warnings only. - Updated `biome.json` to include new linter rules for console usage. - Cleaned up unused imports related to `DEBUG` constants. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
gregfromstl
force-pushed
the
greg/cnct-2483-react-sdk-remove-stray-logs
branch
from
4fbd1cb
to
d3139b2
Compare
graphite-app
bot
deleted the
greg/cnct-2483-react-sdk-remove-stray-logs
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CNCT-2483
PR-Codex overview
This PR focuses on removing
console.logstatements across various files to clean up the code and improve maintainability. It also adjusts some configurations in thebiome.jsonfile related to console logging rules.Detailed summary
console.logstatements from multiple test files and utility functions.biome.jsonto modify rules for console usage, allowing errors and warnings but restricting general logs.send-eip712-transaction.test.ts,smart-wallet-zksync.test.ts, and others by eliminating debugging outputs.