[SDK] Add 2 new Pay functions: convertFiatToCrypto and convertCryptoToFiat #5457
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
🦋 Changeset detectedLatest commit: 07afcee The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
This stack of pull requests is managed by Graphite. Learn more about stacking. |
kien-ngo
changed the title
![graphite-app[bot]](https://avatars.githubusercontent.com/in/158384?s=60&v=4){kind=small}
kien-ngo
requested review from
joaquim-verges,
gregfromstl,
MananTank,
jnsdls and
edwardysun
as code owners
size-limit report 📦
|
kien-ngo
force-pushed
the
kien/pay-convert-endpoints
branch
from
a613e2e
to
980e2d3
Compare
kien-ngo
force-pushed
the
kien/pay-convert-endpoints
branch
from
980e2d3
to
d99b778
Compare
kien-ngo
changed the title
kien-ngo
force-pushed
the
kien/pay-convert-endpoints
branch
from
d99b778
to
b14876f
Compare
kien-ngo
force-pushed
the
kien/pay-convert-endpoints
branch
from
7f86530
to
0e1f12a
Compare
| * The fiat symbol. e.g "usd" | ||
| * Only USD is supported at the moment. | ||
| */ | ||
| to: "usd"; |
There was a problem hiding this comment.
is it usd lowecase or USD uppercase? I see different casing used in the comments / tests
for a currency I think it should be uppercase everywhere
There was a problem hiding this comment.
Updated to uppercase (although it's not case sensitive in the backend)
kien-ngo
force-pushed
the
kien/pay-convert-endpoints
branch
from
0e1f12a
to
dcd6b94
Compare
kien-ngo
force-pushed
the
kien/pay-convert-endpoints
branch
from
dcd6b94
to
07afcee
Compare
| // so we should do some basic input validations before sending the request | ||
|
|
||
| // Make sure it's a valid EVM address | ||
| if (!isAddress(fromTokenAddress)) { | ||
| throw new Error( | ||
| "Invalid fromTokenAddress. Expected a valid EVM contract address", | ||
| ); | ||
| } | ||
| // Make sure it's either a valid contract or a native token address | ||
| if (fromTokenAddress.toLowerCase() !== NATIVE_TOKEN_ADDRESS.toLowerCase()) { | ||
| const bytecode = await getBytecode( | ||
| getContract({ | ||
| address: fromTokenAddress, | ||
| chain, | ||
| client, | ||
| }), | ||
| ).catch(() => undefined); | ||
| if (!bytecode || bytecode === "0x") { | ||
| throw new Error( | ||
| `Error: ${fromTokenAddress} on chainId: ${chain.id} is not a valid contract address.`, |
There was a problem hiding this comment.
The contract validation logic could be extracted to a shared utility function used by both conversion files to reduce duplication
Spotted by Graphite Reviewer (based on CI logs)
Is this helpful? React 👍 or 👎 to let us know.
CNCT-2369
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR introduces two new payment functions:
convertFiatToCryptoandconvertCryptoToFiat, along with their respective tests. These functions facilitate the conversion between fiat currency and cryptocurrency.Detailed summary
convertFiatToCryptofunction infiatToCrypto.ts.convertCryptoToFiatfunction incryptoToFiat.ts.definitions.ts.convertFiatToCryptoinfiatToCrypto.test.ts.convertCryptoToFiatincryptoToFiat.test.ts.