[Dashboard] Remove ListItem (1) and fix some UI issues from the aspect-ratio PR #4846
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Your org has enabled the Graphite merge queue for merging into mainAdd the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix. You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link. |
kien-ngo
requested review from
jnsdls,
MananTank and
joaquim-verges
as code owners
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4846 +/- ##
=======================================
Coverage 47.88% 47.88%
=======================================
Files 1054 1054
Lines 57107 57107
Branches 3926 3926
=======================================
Hits 27347 27347
Misses 29072 29072
Partials 688 688
*This pull request uses carry forward flags. Click here to find out more. |
size-limit report 📦
|
jnsdls
previously requested changes
Sep 30, 2024
apps/dashboard/src/contract-ui/tabs/listings/components/list-form.tsx
Outdated
Show resolved
Hide resolved
apps/dashboard/src/contract-ui/tabs/nfts/components/airdrop-upload.tsx
Outdated
Show resolved
Hide resolved
kien-ngo
force-pushed
the
kien/remove-ListItem-1
branch
from
e006a85
to
9c1d319
Compare
This was referenced Sep 30, 2024
MananTank
requested changes
Sep 30, 2024
jnsdls
reviewed
Sep 30, 2024
kien-ngo
force-pushed
the
kien/remove-ListItem-1
branch
from
9c1d319
to
87a0c75
Compare
MananTank
pushed a commit
that referenced
this pull request
Sep 30, 2024
…t-ratio PR (#4846) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on replacing `List` and `ListItem` components with `ul` and `li` elements across various files, enhancing semantic HTML usage. Additionally, it introduces a new layout for displaying NFT information in `CreateListingsForm`. ### Detailed summary - Deleted `list-label.tsx`. - Replaced `List` and `ListItem` with `ul` and `li` in `EarnReasonSection`, `ReadyPlayer3Landing`, `Hackathon`, `HackathonEarn`, `ContactUs`, `AirdropUploadERC20`, and `UploadStep`. - Updated `CreateListingsForm` to use a `Card` for NFT info display instead of `ListLabel`. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
kien/remove-ListItem-1
branch
from
f946d23
to
cd10c8a
Compare
MananTank
pushed a commit
that referenced
this pull request
Sep 30, 2024
…t-ratio PR (#4846) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on replacing instances of `List` and `ListItem` components with HTML `<ul>` and `<li>` elements across multiple files for consistency and simplicity in the codebase. ### Detailed summary - Removed `List` and `ListItem` components in favor of `<ul>` and `<li>` elements in various components. - Replaced `label` prop structure in `CreateListingsForm` to utilize a `Card` with an `<ul>` for NFT details. - Adjusted layout and styles in several components to accommodate the new list structure. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
kien/remove-ListItem-1
branch
from
cd10c8a
to
a94b665
Compare
MananTank
pushed a commit
that referenced
this pull request
Sep 30, 2024
…t-ratio PR (#4846) ## Problem solved Short description of the bug fixed or feature added <!-- start pr-codex --> --- ## PR-Codex overview This PR focuses on replacing `List` and `ListItem` components with HTML `<ul>` and `<li>` elements across multiple files to improve semantic HTML structure and potentially enhance accessibility. ### Detailed summary - Removed `List` and `ListItem` components in favor of `<ul>` and `<li>` elements in various components. - Updated `label` in `CreateListingsForm` to use a `Card` with structured `<ul>` content. - Adjusted lists in `Hackathon`, `HackathonEarn`, and `ContactUs` pages to use `<ul>` and `<li>`. - Minor styling adjustments for improved layout and alignment. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
kien/remove-ListItem-1
branch
from
a94b665
to
d7d269f
Compare
…t-ratio PR (#4846) Short description of the bug fixed or feature added <!-- start pr-codex --> --- This PR focuses on replacing `List` and `ListItem` components with HTML `<ul>` and `<li>` elements across multiple files to improve semantic HTML structure and potentially enhance accessibility. - Removed `List` and `ListItem` components in favor of `<ul>` and `<li>` elements in various components. - Updated `label` in `CreateListingsForm` to use a `Card` with structured `<ul>` content. - Adjusted lists in `Hackathon`, `HackathonEarn`, and `ContactUs` pages to use `<ul>` and `<li>`. - Minor styling adjustments for improved layout and alignment. > ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}` <!-- end pr-codex -->
MananTank
force-pushed
the
kien/remove-ListItem-1
branch
from
d7d269f
to
5fc07f7
Compare
vercel
bot
temporarily deployed
to
Production – thirdweb_playground
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem solved
Short description of the bug fixed or feature added
PR-Codex overview
This PR focuses on updating various components to replace
ListandListItemfrom@chakra-ui/reactwith standard HTML<ul>and<li>elements for better semantic HTML structure. It also includes the removal of theListLabelcomponent in favor of a more detailed inline structure for labels.Detailed summary
list-label.tsxcomponent.ListandListItemwith<ul>and<li>inEarnReasonSection,ReadyPlayer3Landing,Hackathon,HackathonEarn,AirdropUploadERC20, andAirdropUploadcomponents.CreateListingsFormto render NFT details directly within aCard.ContactUscomponent to use<Flex>for layout instead ofList.ListandListItemimports from various components to clean up unused code.