Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dashboard] Feature: Create ecosystem auth options #4798

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gregfromstl
Copy link
Member

@gregfromstl gregfromstl commented Sep 25, 2024

Dependent on https://github.com/thirdweb-dev/api-server/pull/1084


PR-Codex overview

This PR introduces support for authentication options in the ecosystem creation process. It modifies the relevant forms and hooks to handle an array of authentication options, enhancing the user experience by allowing multiple selections.

Detailed summary

  • Added authOptions property to the useCreateEcosystem hook.
  • Updated CreateEcosystemForm to include authOptions in the form schema and default values.
  • Implemented a checkbox selection for authOptions in the CreateEcosystemForm.
  • Modified checkbox logic to handle optional authOptions safely.

✨ Ask PR-Codex anything about this PR by commenting with /codex {your question}

@gregfromstl gregfromstl added DO NOT MERGE This pull request is still in progress and is not ready to be merged. Dashboard Involves changes to the Dashboard. Feature Adds new functionality to the public API. labels Sep 25, 2024
@gregfromstl gregfromstl self-assigned this Sep 25, 2024
Copy link

vercel bot commented Sep 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
thirdweb-www ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 27, 2024 0:26am
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
docs-v2 ⬜️ Skipped (Inspect) Sep 27, 2024 0:26am
thirdweb_playground ⬜️ Skipped (Inspect) Sep 27, 2024 0:26am
wallet-ui ⬜️ Skipped (Inspect) Sep 27, 2024 0:26am

Copy link

changeset-bot bot commented Sep 25, 2024

⚠️ No Changeset found

Latest commit: b293cba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

graphite-app bot commented Sep 25, 2024

Your org has enabled the Graphite merge queue for merging into main

Add the label “merge-queue” to the PR and Graphite will automatically add it to the merge queue when it’s ready to merge. Or use the label “hotfix” to add to the merge queue as a hot fix.

You must have a Graphite account and log in to Graphite in order to use the merge queue. Sign up using this link.

Copy link

codecov bot commented Sep 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.67%. Comparing base (21b032d) to head (b293cba).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4798   +/-   ##
=======================================
  Coverage   47.67%   47.67%           
=======================================
  Files        1051     1051           
  Lines       56715    56715           
  Branches     3894     3894           
=======================================
  Hits        27040    27040           
  Misses      28988    28988           
  Partials      687      687           
Flag Coverage Δ *Carryforward flag
legacy_packages 65.68% <ø> (ø) Carriedforward from 82ab703
packages 43.40% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

Copy link
Contributor

github-actions bot commented Sep 25, 2024

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
thirdweb (esm) 41.93 KB (0%) 839 ms (0%) 573 ms (+28.8% 🔺) 1.5 s
thirdweb (cjs) 101.55 KB (0%) 2.1 s (0%) 1.1 s (+30.11% 🔺) 3.2 s
thirdweb (minimal + tree-shaking) 4.82 KB (0%) 97 ms (0%) 39 ms (+13.78% 🔺) 135 ms
thirdweb/chains (tree-shaking) 498 B (0%) 10 ms (0%) 25 ms (+94.75% 🔺) 35 ms
thirdweb/react (minimal + tree-shaking) 16.78 KB (0%) 336 ms (0%) 149 ms (+77.32% 🔺) 484 ms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Dashboard Involves changes to the Dashboard. DO NOT MERGE This pull request is still in progress and is not ready to be merged. Feature Adds new functionality to the public API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant