Skip to content

Commit

Permalink
Fix connect button border in firefox (#4160)
Browse files Browse the repository at this point in the history
Corrects an issue with the border visibility in firefox by explicitly specifying the div height

<!-- start pr-codex -->

---

## PR-Codex overview
This PR focuses on fixing the connect button border issue on Firefox browser.

### Detailed summary
- Added `height: "50px"` to the button style in `Details.tsx` for proper display on Firefox.

> ✨ Ask PR-Codex anything about this PR by commenting with `/codex {your question}`

<!-- end pr-codex -->
  • Loading branch information
gregfromstl committed Aug 18, 2024
1 parent f0d6e34 commit e0dcc64
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 0 deletions.
5 changes: 5 additions & 0 deletions .changeset/seven-gorillas-speak.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"thirdweb": patch
---

Fix connect button border on firefox browser
Original file line number Diff line number Diff line change
Expand Up @@ -214,6 +214,7 @@ export const ConnectedWalletDetails: React.FC<{
border: `1px solid ${theme.colors.borderColor}`,
textOverflow: "ellipsis",
width: "115px",
height: "50px",

Check warning on line 217 in packages/thirdweb/src/react/web/ui/ConnectWallet/Details.tsx

View check run for this annotation

Codecov / codecov/patch

packages/thirdweb/src/react/web/ui/ConnectWallet/Details.tsx#L217

Added line #L217 was not covered by tests
whiteSpace: "nowrap",
borderRadius: `0 ${radius.md} ${radius.md} 0`,
}}
Expand Down

0 comments on commit e0dcc64

Please sign in to comment.