Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add request to dial callback #45

Merged
merged 4 commits into from
Jan 8, 2024
Merged

add request to dial callback #45

merged 4 commits into from
Jan 8, 2024

Conversation

kotori2
Copy link
Contributor

@kotori2 kotori2 commented Dec 20, 2023

Close #44

@kotori2
Copy link
Contributor Author

kotori2 commented Dec 20, 2023

> go test ./...
ok      github.com/things-go/go-socks5  (cached)
ok      github.com/things-go/go-socks5/bufferpool       5.189s
ok      github.com/things-go/go-socks5/statute  2.811s

@thinkgos
Copy link
Member

@kotori2 Non-compatible change, suggest add another dial(Such as CustomDial) to overiwrite default dial, which priority higher than dial

@kotori2
Copy link
Contributor Author

kotori2 commented Dec 20, 2023

@kotori2 Non-compatible change, suggest add another dial(Such as CustomDial) to overiwrite default dial, which priority higher than dial

Yeah that's what I'm thinking about in the first place...
Gonna make this PR as draft first.

@kotori2 kotori2 marked this pull request as draft December 20, 2023 02:55
@kotori2
Copy link
Contributor Author

kotori2 commented Jan 6, 2024

done

> go test ./...                
ok      github.com/things-go/go-socks5  1.378s
ok      github.com/things-go/go-socks5/bufferpool       4.424s
ok      github.com/things-go/go-socks5/statute  0.285s

@kotori2 kotori2 marked this pull request as ready for review January 6, 2024 02:10
Copy link

codecov bot commented Jan 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6191a34) 62.19% compared to head (5438f4d) 63.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
+ Coverage   62.19%   63.13%   +0.94%     
==========================================
  Files          14       14              
  Lines         775      784       +9     
==========================================
+ Hits          482      495      +13     
+ Misses        233      230       -3     
+ Partials       60       59       -1     
Flag Coverage Δ
unittests 63.13% <100.00%> (+0.94%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kotori2
Copy link
Contributor Author

kotori2 commented Jan 6, 2024

Do I need to add test cases for the options?

@thinkgos thinkgos merged commit e9cb1db into things-go:master Jan 8, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR] Dial callback with request information
2 participants