fixed orientation generation of cached images (small ones and thumbs) #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The images are almost in the right representation now. The generated files (small ones and thumbs) do have the right angle now, but they still need to be mirrored horizontally.
This should be a fix for issue #286.
I tested it with the images from here (https://magnushoff.com/jpeg-orientation.html).
The only problem left (for me) is this:
If the generated small image (?t=Img&...) has exif orientation information (3-8), because it's width and height is lower than 1200, the image doesn't get rotated by the browser.