Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A few fixes and improvements #355

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

vletroye
Copy link

@vletroye vletroye commented Nov 2, 2017

Hi There. Let me first apologize if not complying with a 'state of the art' use of GitHub. I am far from confortable with the Git commands...

Here are a few fixes:

  • Fix use fo 'ESC' which could be pressed in various situation and toggling fullscreen/normal screen, missing the layout when stopping/re-starting slideshow.
  • Fix cycling in slideshow mode when reaching the first/last images

And a few improvements (at least as far as I am concerned! It's a matter of point of view)

  • Instead of loading "big" images in the current page, I open them in fullscreen mode, just as made by the slideshow
  • I did also attempt to add a smooth transition between images in slideshow mode (a dirty solution).
  • Finally, I wanted to lazy load the images while scrolling in the pane/linear-pane. This is really not yet perfect, especially with IE/Edge* but works fine enough for me, within Chrome. (*: I notice mainly perf issues/freeze)

@vletroye vletroye changed the title A few fixes and improvments A few fixes and improvements Nov 2, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant