Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure tessellation of polygon2 returns a collection of triangle2 #89

Open
wants to merge 1 commit into
base: feature/no-org
Choose a base branch
from

Conversation

dgtized
Copy link
Contributor

@dgtized dgtized commented Dec 31, 2021

The return type of ITessellate tessellate for Circle, Triangle2, and Rect all
return a collection of Triangle2. However, calling tessellate on a polygon returned a
collection of point triplets. This patch ensures uniformity in the return type
for tessellating 2d shapes.

The return type of ITessellate tessellate for Circle, Triangle2, and Rect all
return a collection of Triangle2. However, calling tessellate on a polygon returned a
collection of point triplets. This patch ensures uniformity in the return type
for tessellating 2d shapes.
@dgtized
Copy link
Contributor Author

dgtized commented Dec 31, 2021

Note that it appears that all of the 3d shapes return g/faces (which is a collection of Vec3 points), except for geom/quad which returns a set of Triangle3. So it might be useful to ensure uniformity there too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant