Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Large PR, cleanup, prettifying, add device selection and configs. More nodes. #5

Open
wants to merge 29 commits into
base: master
Choose a base branch
from

Conversation

AshMartian
Copy link

@AshMartian AshMartian commented Nov 28, 2018

I am working on a substantial PR that adds many new features to this node-red ring doorbell integration. I have a Ring Doorbell, and Floodlight camera that I'll be integrating with. So far I've optimized and refactored some code for config settings (only need to enter username/password once), security for passwords, and am integrating device selection.

Here are the current plans before merging, please hold off merging until these are complete.

  • Add config into separate node to be used multiple times
  • Change text color to white on nodes for readability
  • Rename single ring node into ring-action, this is a "breaking" change that warrants a substantial version increase (3.0?) Can add backwards compatibility, but undesirable for the long run
  • Add device selection to nodes
  • New Node for getting all devices
  • New node for getting device status (health)
    • Will be able to send an alert via ifttt or other node-red connections if a battery powered device needs charging
  • New node for getting live camera stream url (add proxy to node-red server)
  • New node for retrieving previous recordings/actions video url

I am using this to integrate Ring into Google Home. Currently there is no support for Ring -> Google Home for push notifications or viewing live feeds/previous recordings. I've already got this code working with my Google Homes and Google Home Hub for broadcast tts notifications on motion and dings.

screen shot 2018-11-28 at 12 00 46 pm

screen shot 2018-11-28 at 12 04 23 pm

screen shot 2018-11-28 at 12 04 29 pm

Thank you for creating this repo, I'm happy to be able to contribute.

@AshMartian
Copy link
Author

screen shot 2018-11-28 at 8 35 03 pm

@AshMartian
Copy link
Author

Getting video stream may be very difficult here, See jimhigson/ring-api#1

@tt2g89
Copy link

tt2g89 commented Oct 16, 2019

Hi @blandman,
Is it possible to release a snapshot of the latest development?
Maybe later streaming will be working by the API.

@thevalyreangroup
Copy link
Owner

Hey @blandman I'm going to be revisiting this repo in the coming weeks. I have largely abandoned it in that past year or two and I now see there is a lot of interest in it. Are you still working on this PR?

@tt2g89
Copy link

tt2g89 commented Nov 30, 2020

Hey @thevalyreangroup Do you have any plans to rework your plugin in the nearer future?
It would be incredible to have a possibility to get notified by the plugin and maybe with luck have the possibility to stream the video. :)
Thanks to @blandman for contributing!

Found that one: https://www.npmjs.com/package/ring-client-api, but I'm unable to develop unfortunately... :(

@jeroenst
Copy link

Wow, seams this plugin is pretty dead.. :-(

@thevalyreangroup
Copy link
Owner

thevalyreangroup commented May 19, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snapshot
4 participants