Case insensitive username comparison #421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
signer names (GitHub usernames) are compared in quite a few places: Ensure that comparisons are case-insensitive by always processing lowercase names * When reading in signer configuration from .tuf-on-ci-sign.ini, convert to lower case * When taking in signer names as input when modifying a delegation, convert to lower case
Use a capital letter in both the config file and in tuf-on-ci-delegate input. Most of the changes are just ensuring the filepaths of test results stay the same.
jku
changed the title
kommendorkapten
approved these changes
Sep 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure user names are handled as lower case
signer names (GitHub usernames) are compared in quite a few places: Ensure that comparisons are case-insensitive by always processing lowercase names
Use a capital letter in those two cases in e2e tests.