Update tuf version #115
Closed
Update tuf version #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This simplifies the handling quite a lot: * status() result is now a lot easier to understand * root version is now checked by get_root_verification_result(): tuf-on-ci does not need to * No need to build a list of signed and unsigned signers anymore (just translate keys to signer names)
jku
commented
Feb 6, 2024
| @@ -144,7 +149,7 @@ def _role_status(repo: CIRepository, role: str, event_name) -> bool: | |||
| if status.message: | |||
| click.echo(f"**Error**: {status.message}") | |||
|
|
|||
| return role_is_valid and not status.invites | |||
There was a problem hiding this comment.
SigningStatus makes sure it is not valid if there are invites so this is safe
* Use verify_delegate() from Root, Targets * Use helpers like Repository.root(), Repository.targets()
|
FYI @lukpueh in case you are interested. |
jku
commented
Feb 6, 2024
Comment on lines
-289
to
-293
| # Specification: root version must be x+1, not just larger | ||
| if prev_md and prev_md.signed != md.signed: | ||
| if md.signed.version != prev_md.signed.version + 1: | ||
| return False, f"Version {md.signed.version} is not valid for root" | ||
|
|
There was a problem hiding this comment.
This check is handled by Root.get_root_verification_result()
|
This update is now possible as tuf 4.0 has been released. There is no rush though: the securesystemslib pinning in #243 handles the main reason to upgrade quickly |
This was referenced Apr 4, 2024
|
This is still in limbo as tuf, sigstore and securesystemslib all have had changes that need releases before the three are compatible again :( Basically:
|
|
Closing this for now, we have enough open PRs without drafts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an update to current (unreleased) tuf API, draft until tuf makes a release:
The verification result changes mean some modifications in the code here, mostly in a good direction.